Attention is currently required from: Felix Held.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57346 )
Change subject: mb/intel/leafhill,minnow3: remove ADD_FSP_BINARIES config override
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
I'm not sure about these - I think it's entirely reasonable to want to add an FSP from someplace other than the intel repository. Being able to override that seems like something we'd want to keep. Maybe that's addressed in another patch that I haven't gotten to yet, but if not, we should make sure that case can still be handled.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57346
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I23439f3134eef9460625addbff7efd64c5f65ae5
Gerrit-Change-Number: 57346
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin Roth
martinroth@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 03 Sep 2021 15:21:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment