Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35321 )
Change subject: soc/fsp_broadwell_de: Add devhide functionality
......................................................................
Patch Set 10:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35321/10/src/soc/intel/fsp_broadwel...
File src/soc/intel/fsp_broadwell_de/southcluster.c:
https://review.coreboot.org/c/coreboot/+/35321/10/src/soc/intel/fsp_broadwel...
PS10, Line 268: iio_hide(slot, func);
yeah, this way iio_hide() can be used in bootblock and ramstage. […]
I see. Thanks for the explanation.
https://review.coreboot.org/c/coreboot/+/35321/10/src/soc/intel/fsp_broadwel...
File src/soc/intel/fsp_broadwell_de/ubox.c:
https://review.coreboot.org/c/coreboot/+/35321/10/src/soc/intel/fsp_broadwel...
PS10, Line 28:
sure will do it. But in interest of time lets land this as is.
Yes, follow-up is fine with me.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35321
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2fcac5b7d9a7a52a2801c010bfccf247f2a44581
Gerrit-Change-Number: 35321
Gerrit-PatchSet: 10
Gerrit-Owner: Andrey Petrov
anpetrov@fb.com
Gerrit-Reviewer: Andrey Petrov
anpetrov@fb.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 24 Sep 2019 06:11:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Werner Zeh
werner.zeh@siemens.com
Comment-In-Reply-To: Andrey Petrov
anpetrov@fb.com
Gerrit-MessageType: comment