Attention is currently required from: Ana Carolina Cabral, Anand Vaikar, Bao Zheng, Felix Held, Marshall Dawson, Paul Menzel.
Maximilian Brune has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/84373?usp=email )
Change subject: util/amdfwtool: Add binary parsing ......................................................................
Patch Set 9:
(3 comments)
File util/amdfwtool/amdfwtool.c:
https://review.coreboot.org/c/coreboot/+/84373/comment/6009d1b5_116aaf67?usp... : PS8, Line 263: { .type = AMD_FW_MINIMSMU, .subprog = 0, .level = PSP_BOTH | PSP_LVL2_AB }, : { .type = AMD_FW_MINIMSMU, .subprog = 1, .level = PSP_BOTH | PSP_LVL2_AB },
this adds the inst=0, subprog=1 case, but drops the inst=1, subprog=0 case
The only thing I know for certain is that I need the subprog=1,inst=0 case to keep my board booting. I changed it up in order to not remove the inst=1,subprog=0 case.
https://review.coreboot.org/c/coreboot/+/84373/comment/ed1b488f_72948d04?usp... : PS8, Line 324: { .type = AMD_BIOS_APOB_NV, .level = BDT_BOTH },
iirc glinda doesn't use/have a level 1 bios directory table
Done
https://review.coreboot.org/c/coreboot/+/84373/comment/1a3dff7f_33849aeb?usp... : PS8, Line 381: { .type = AMD_BIOS_MP2_CFG, .level = BDT_BOTH },
Same as above.
Done