Change in coreboot[master]: mb/samsung/lumpy: Do not overwrite pei_data

[Angel Pons (Code Review)]

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43036 )

Change subject: mb/samsung/lumpy: Do not overwrite pei_data
......................................................................

mb/samsung/lumpy: Do not overwrite pei_data

Most of the values are already set in northbridge code.

Change-Id: I7202c0de460134e86bf0843ec6024d9afd5f3708
Signed-off-by: Angel Pons 
---
M src/mainboard/samsung/lumpy/early_init.c
1 file changed, 22 insertions(+), 43 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/43036/1

diff --git a/src/mainboard/samsung/lumpy/early_init.c b/src/mainboard/samsung/lumpy/early_init.c
index 091cbc5..d3012d8 100644
--- a/src/mainboard/samsung/lumpy/early_init.c
+++ b/src/mainboard/samsung/lumpy/early_init.c
@@ -115,50 +115,29 @@

void mainboard_fill_pei_data(struct pei_data *pei_data)
 {
-	struct pei_data pei_data_template = {
-		.pei_version = PEI_VERSION,
-		.mchbar = (uintptr_t)DEFAULT_MCHBAR,
-		.dmibar = (uintptr_t)DEFAULT_DMIBAR,
-		.epbar = DEFAULT_EPBAR,
-		.pciexbar = CONFIG_MMCONF_BASE_ADDRESS,
-		.smbusbar = SMBUS_IO_BASE,
-		.wdbbar = 0x4000000,
-		.wdbsize = 0x1000,
-		.hpet_address = CONFIG_HPET_ADDRESS,
-		.rcba = (uintptr_t)DEFAULT_RCBABASE,
-		.pmbase = DEFAULT_PMBASE,
-		.gpiobase = DEFAULT_GPIOBASE,
-		.thermalbase = 0xfed08000,
-		.system_type = 0, // 0 Mobile, 1 Desktop/Server
-		.tseg_size = CONFIG_SMM_TSEG_SIZE,
-		.spd_addresses = { 0xa0, 0x00,0x00,0x00 },
-		.ts_addresses = { 0x30, 0x00, 0x00, 0x00 },
-		.ec_present = 1,
-		// 0 = leave channel enabled
-		// 1 = disable dimm 0 on channel
-		// 2 = disable dimm 1 on channel
-		// 3 = disable dimm 0+1 on channel
-		.dimm_channel0_disabled = 2,
-		.dimm_channel1_disabled = 2,
-		.max_ddr3_freq = 1333,
-		.usb_port_config = {
-			{ 1, 0, 0x0080 }, /* P0: Port 0      (OC0) */
-			{ 1, 1, 0x0080 }, /* P1: Port 1      (OC1) */
-			{ 1, 0, 0x0040 }, /* P2: MINIPCIE1   (no OC) */
-			{ 1, 0, 0x0040 }, /* P3: MMC         (no OC) */
-			{ 0, 0, 0x0000 }, /* P4: Empty */
-			{ 0, 0, 0x0000 }, /* P5: Empty */
-			{ 0, 0, 0x0000 }, /* P6: Empty */
-			{ 0, 0, 0x0000 }, /* P7: Empty */
-			{ 1, 4, 0x0040 }, /* P8: MINIPCIE2   (no OC) */
-			{ 0, 4, 0x0000 }, /* P9: Empty */
-			{ 0, 4, 0x0000 }, /* P10: Empty */
-			{ 1, 4, 0x0040 }, /* P11: Camera     (no OC) */
-			{ 0, 4, 0x0000 }, /* P12: Empty */
-			{ 0, 4, 0x0000 }, /* P13: Empty */
-		},
+	pei_data->system_type   = 0; /* 0 Mobile, 1 Desktop/Server */
+	pei_data->ec_present    = 1;
+	pei_data->spd_addresses = { 0xa0, 0x00, 0x00, 0x00 };
+	pei_data->ts_addresses  = { 0x30, 0x00, 0x00, 0x00 };
+	pei_data->max_ddr3_freq = 1333;
+
+	pei_data->usb_port_config = {
+		{ 1, 0, 0x0080 }, /* P0: Port 0      (OC0) */
+		{ 1, 1, 0x0080 }, /* P1: Port 1      (OC1) */
+		{ 1, 0, 0x0040 }, /* P2: MINIPCIE1   (no OC) */
+		{ 1, 0, 0x0040 }, /* P3: MMC         (no OC) */
+		{ 0, 0, 0x0000 }, /* P4: Empty */
+		{ 0, 0, 0x0000 }, /* P5: Empty */
+		{ 0, 0, 0x0000 }, /* P6: Empty */
+		{ 0, 0, 0x0000 }, /* P7: Empty */
+		{ 1, 4, 0x0040 }, /* P8: MINIPCIE2   (no OC) */
+		{ 0, 4, 0x0000 }, /* P9: Empty */
+		{ 0, 4, 0x0000 }, /* P10: Empty */
+		{ 1, 4, 0x0040 }, /* P11: Camera     (no OC) */
+		{ 0, 4, 0x0000 }, /* P12: Empty */
+		{ 0, 4, 0x0000 }, /* P13: Empty */
    };
-	*pei_data = pei_data_template;
+
    memcpy(pei_data->spd_data[2], locate_spd(), 256);
 }

[Angel Pons (Code Review)]

Angel Pons has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/43036 )

Change subject: mb/samsung/lumpy: Do not overwrite pei_data
......................................................................

Abandoned