Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43922 )
Change subject: mb/intel/cedarisland: Update UDP option offsets for FSP-M ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/43922/3/src/mainboard/intel/cedaris... File src/mainboard/intel/cedarisland_crb/romstage.c:
https://review.coreboot.org/c/coreboot/+/43922/3/src/mainboard/intel/cedaris... PS3, Line 9: void *start = (void *) m_cfg;
Doing aritmetics on pointers to void is undefined behaviour in C.
Yes I know. This has already been removed in CB:43923
https://review.coreboot.org/c/coreboot/+/43922/3/src/mainboard/intel/cedaris... PS3, Line 10: : // BoardId (offset 0x00B9) : write8(start + 185, 0x1d); : : // BoardTypeBitmask (offset 0x00A0) : write32(start + 160, 0x11111111); : : // DebugPrintLevel (offset 0x006D) : write8(start + 109, 8); : : // KtiLinkSpeedMode (offset 0x0080) : write8(start + 128, 0); : : // KtiPrefetchEn (offset 0x0075) : write8(start + 117, 2);
Is there no struct to do this?
See next patch - CB:43923 The offsets in the structure are different from the current ones here. Perhaps the old version of fsp was used for cedarisland. So I decided to fix it carefully using a few patches:
1 - this 2 - CB:43923, mb/intel/cedarisland: Use FSP_M_CONFIG structure 3 - CB:43924, mb/intel/cedarisland: Remove dublicated code
-
Maxim Polyakov (Code Review)