Change in coreboot[master]: configs: Build test SPI console

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Patrick Rudolph (Code Review)

4 Jan 2020 4 Jan '20

12:52 p.m.

Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38174 )

Change subject: configs: Build test SPI console ......................................................................

configs: Build test SPI console

Change-Id: I70467862b238f8be62eafb5532ede9882dd2f41a Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com --- R configs/config.up_squared.vboot_spi_flash_console 1 file changed, 1 insertion(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/38174/1

diff --git a/configs/config.up_squared.vboot b/configs/config.up_squared.vboot_spi_flash_console similarity index 62% rename from configs/config.up_squared.vboot rename to configs/config.up_squared.vboot_spi_flash_console index 130c02f..a73dfee 100644 --- a/configs/config.up_squared.vboot +++ b/configs/config.up_squared.vboot_spi_flash_console @@ -1,2 +1,3 @@ CONFIG_VENDOR_UP=y CONFIG_VBOOT=y +CONSOLE_SPI_FLASH=y

Attachments:

attachment.htm (text/html — 2.3 KB)

Show replies by date

Mimoja (Code Review)

4 Jan 4 Jan

1:14 p.m.

Mimoja has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38174 )

Change subject: configs: Build test SPI console ......................................................................

Patch Set 1: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/38174 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I70467862b238f8be62eafb5532ede9882dd2f41a Gerrit-Change-Number: 38174 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Mimoja coreboot@mimoja.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Comment-Date: Sat, 04 Jan 2020 12:14:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Kyösti Mälkki (Code Review)

1:17 p.m.

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38174 )

Change subject: configs: Build test SPI console ......................................................................

Patch Set 1:

(1 comment)

rebase on CB:38171 ?

https://review.coreboot.org/c/coreboot/+/38174/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/38174/1//COMMIT_MSG@7 PS1, Line 7: configs: Build test SPI console flashconsole ?

SPI_CONSOLE is something different (capture with EM100 ?).

-- To view, visit https://review.coreboot.org/c/coreboot/+/38174 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I70467862b238f8be62eafb5532ede9882dd2f41a Gerrit-Change-Number: 38174 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Mimoja coreboot@mimoja.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Comment-Date: Sat, 04 Jan 2020 12:17:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Patrick Rudolph (Code Review)

1:34 p.m.

New subject: Change in coreboot[master]: configs: Build test flashconsole

Hello Kyösti Mälkki, Mimoja, build bot (Jenkins), Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38174

to look at the new patch set (#2).

Change subject: configs: Build test flashconsole ......................................................................

configs: Build test flashconsole

Change-Id: I70467862b238f8be62eafb5532ede9882dd2f41a Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com --- D configs/config.up_squared.vboot A configs/config.up_squared.vboot_spi_flash_console 2 files changed, 3 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/38174/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/38174 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I70467862b238f8be62eafb5532ede9882dd2f41a Gerrit-Change-Number: 38174 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Mimoja coreboot@mimoja.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Patrick Rudolph (Code Review)

1:34 p.m.

New subject: Change in coreboot[master]: configs: Build test flashconsole

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38174 )

Change subject: configs: Build test flashconsole ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38174/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/38174/1//COMMIT_MSG@7 PS1, Line 7: configs: Build test SPI console

...

flashconsole ? […]

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/38174 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I70467862b238f8be62eafb5532ede9882dd2f41a Gerrit-Change-Number: 38174 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Mimoja coreboot@mimoja.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sat, 04 Jan 2020 12:34:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-MessageType: comment

Kyösti Mälkki (Code Review)

1:35 p.m.

New subject: Change in coreboot[master]: configs: Build test flashconsole

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38174 )

Change subject: configs: Build test flashconsole ......................................................................

Patch Set 2: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/38174 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I70467862b238f8be62eafb5532ede9882dd2f41a Gerrit-Change-Number: 38174 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Mimoja coreboot@mimoja.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sat, 04 Jan 2020 12:35:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Angel Pons (Code Review)

3:18 p.m.

New subject: Change in coreboot[master]: configs: Build test flashconsole

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38174 )

Change subject: configs: Build test flashconsole ......................................................................

Patch Set 2: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/38174 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I70467862b238f8be62eafb5532ede9882dd2f41a Gerrit-Change-Number: 38174 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Mimoja coreboot@mimoja.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sat, 04 Jan 2020 14:18:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Nico Huber (Code Review)

10 Jan 10 Jan

4:13 p.m.

New subject: Change in coreboot[master]: configs: Build test flashconsole

Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38174 )

Change subject: configs: Build test flashconsole ......................................................................

configs: Build test flashconsole

Change-Id: I70467862b238f8be62eafb5532ede9882dd2f41a Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/38174 Reviewed-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- D configs/config.up_squared.vboot A configs/config.up_squared.vboot_spi_flash_console 2 files changed, 3 insertions(+), 2 deletions(-)

Approvals: build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, approved Angel Pons: Looks good to me, approved

diff --git a/configs/config.up_squared.vboot b/configs/config.up_squared.vboot deleted file mode 100644 index 130c02f..0000000 --- a/configs/config.up_squared.vboot +++ /dev/null @@ -1,2 +0,0 @@ -CONFIG_VENDOR_UP=y -CONFIG_VBOOT=y diff --git a/configs/config.up_squared.vboot_spi_flash_console b/configs/config.up_squared.vboot_spi_flash_console new file mode 100644 index 0000000..a537035 --- /dev/null +++ b/configs/config.up_squared.vboot_spi_flash_console @@ -0,0 +1,3 @@ +CONFIG_VENDOR_UP=y +CONFIG_VBOOT=y +CONFIG_CONSOLE_SPI_FLASH=y

-- To view, visit https://review.coreboot.org/c/coreboot/+/38174 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I70467862b238f8be62eafb5532ede9882dd2f41a Gerrit-Change-Number: 38174 Gerrit-PatchSet: 3 Gerrit-Owner: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Mimoja coreboot@mimoja.de Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

1577

days inactive

1583

days old

coreboot-gerrit@coreboot.org

7 comments

5 participants

tags (0)

participants (5)

Angel Pons (Code Review)
Kyösti Mälkki (Code Review)
Mimoja (Code Review)
Nico Huber (Code Review)
Patrick Rudolph (Code Review)