Attention is currently required from: Matt DeVillier.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80647?usp=email )
Change subject: soc/intel/common/lpc_lib: Demote printk for IO base value 0
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
Patchset:
PS1:
If this function gets called with a 0 value, that's most likely a bug at the
calling site. For instance like the one that is fixed by the parent commit.
It probably wouldn't have been discovered if this wasn't an error message.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80647?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I593f8e3c7eb9e877f89568fd63eabe12bb777f93
Gerrit-Change-Number: 80647
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Comment-Date: Sun, 25 Feb 2024 13:18:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment