Attention is currently required from: Paul Menzel. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62831 )
Change subject: xcompile: Hard-code gcc-12 ......................................................................
Patch Set 1:
(3 comments)
Patchset:
PS1: I'm not sure if this was supposed to be a private patch, but if it's for submission, we need to qualify the use of gcc-12.
File util/xcompile/xcompile:
https://review.coreboot.org/c/coreboot/+/62831/comment/a6be97bd_adc2e2f5 PS1, Line 64: gcc-12 I'm not sure that this is what we want here. What about other systems than debian?
How about adding a check for gcc-12 instead?
if program_exists "${XGCCPATH}/gcc"; then HOSTCC="${XGCCPATH}/gcc" elif program_exists gcc-12; then HOSTCC=gcc-12 elif program_exists gcc; then HOSTCC=gcc elif program_exists cc; then HOSTCC=cc else die "no host compiler found" fi
https://review.coreboot.org/c/coreboot/+/62831/comment/6300c114_17a4c3cf PS1, Line 302: NM_${TARCH}:=${GCCPREFIX}gcc-nm-12 Here, let's check for $HOSTCC == gcc-12 before setting this, both here and below.
ifeq (${HOSTCC},gcc-12) NM_${TARCH}:=${GCCPREFIX}gcc-nm-12 AR_${TARCH}:=${GCCPREFIX}gcc-ar-12 else NM_${TARCH}:=${GCCPREFIX}gcc-nm AR_${TARCH}:=${GCCPREFIX}gcc-ar endif