Martin Roth has posted comments on this change. ( https://review.coreboot.org/19054 )
Change subject: Documentation: Describe libgfxinit hook-up ......................................................................
Patch Set 2:
(3 comments)
Maybe say something about building the Ada compiler? Should we enable it by default in the makefile target for crossgcc-i386?
https://review.coreboot.org/#/c/19054/2/Documentation/gfx/libgfxinit.md File Documentation/gfx/libgfxinit.md:
PS2, Line 13: Core i This looks awkward - maybe "Intel Core i3/i5/i7 processor line"
PS2, Line 57: This indentation causes a code block with just the rest of this line in it.
https://daringfireball.net/projects/markdown/syntax#precode
PS2, Line 59: failed `0`. Currently, only the case that no display : could be found counts as failure. A failure at a la- : ter stage (e.g. failure to train a DP) is not propa- : gated. same - indentation causes a code block containing the rest of this text.