Attention is currently required from: Jeremy Soller, Tim Wawrzynczak, Patrick Rudolph.
Tim Crawford has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56946 )
Change subject: soc/intel/tigerlake: Add PCH-H GPIO definitions
......................................................................
Patch Set 2:
(2 comments)
File src/soc/intel/tigerlake/gpio_pch_h.c:
https://review.coreboot.org/c/coreboot/+/56946/comment/08d38ba1_19a6bc9a
PS2, Line 37: * linux/drivers/pinctrl/intel/pinctrl-tigerlake.c
These were updated recently (2f658f7a395) so may need to test with 5.14-rc6.
File src/soc/intel/tigerlake/include/soc/gpio_soc_defs_pch_h.h:
https://review.coreboot.org/c/coreboot/+/56946/comment/c992ad9b_01f563e8
PS2, Line 117: /* Group vGPIO_0 */
Wasn't sure if these should be prefixed, since vGPIO isn't either.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56946
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If9a0fd1691fc1143b5c214a2613d270199367659
Gerrit-Change-Number: 56946
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Crawford
tcrawford@system76.com
Gerrit-Reviewer: Jeremy Soller
jeremy@system76.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jeremy Soller
jeremy@system76.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Fri, 20 Aug 2021 22:11:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment