Attention is currently required from: Angel Pons, Jean Lucas, Lean Sheng Tan, Martin L Roth, Matt DeVillier, Nicholas Chin, Nico Huber, Sean Rhodes.
Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/82000?usp=email )
Change subject: payloads/edk2: Add Kconfig to use LAPIC timer
......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS5:
I'm not sure on the performance gain. It's set as an interrupt handler, so it may be pretty hot code, but have its time cost split throughout all drivers. But on the other hand, it's just some interrupts. There are probably other things with greater time complexity (DEBUG images, for example, both in loading the binaries, as well as using the debug libraries).
Also, did you mean to keep this comment unresolved?
Yes, I thought it should be added to the commit message or Kconfig help, but I sent it before I decided that Kconfig was best: to tell users. Then I sent the follow-up before I refreshed, so I didn't see your comment.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/82000?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I33144d6c1c120e7faa47b99e8262b0997c45c9b9
Gerrit-Change-Number: 82000
Gerrit-PatchSet: 5
Gerrit-Owner: Jean Lucas
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Jean Lucas
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-Comment-Date: Fri, 19 Apr 2024 18:03:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-MessageType: comment