Change in ...coreboot[master]: util/inteltool: Shrink buffer size

[Jacob Garber (Code Review)]

Jacob Garber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33944

Change subject: util/inteltool: Shrink buffer size
......................................................................

util/inteltool: Shrink buffer size

512 bytes is much too big for this buffer, which only needs to hold a
path that will have a length of at most 20. The large buffer size also
triggers a -Wformat-truncation warning with GCC since it is later
printed into the smaller temp_string array, so shrink it down to
something reasonable.

Change-Id: I6a136d1a739c782b368d5035db9bc25cf5b9599b
Signed-off-by: Jacob Garber 
---
M util/inteltool/cpu.c
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/33944/1

diff --git a/util/inteltool/cpu.c b/util/inteltool/cpu.c
index ef2df3c..04870fc 100644
--- a/util/inteltool/cpu.c
+++ b/util/inteltool/cpu.c
@@ -110,7 +110,7 @@

static int open_and_seek(int cpu, unsigned long msr, int mode, int *fd)
 {
-	char dev[512];
+	char dev[32];
    char temp_string[50];

snprintf(dev, sizeof(dev), "/dev/cpu/%d/msr", cpu);

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33944 )

Change subject: util/inteltool: Shrink buffer size
......................................................................

Patch Set 1: Code-Review+1

Change in coreboot[master]: util/inteltool: Shrink buffer size

[David Hendricks (Code Review)]

David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33944 )

Change subject: util/inteltool: Shrink buffer size
......................................................................

Patch Set 1: Code-Review+2

Change in coreboot[master]: util/inteltool: Shrink buffer size

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33944 )

Change subject: util/inteltool: Shrink buffer size
......................................................................

Patch Set 1: Code-Review+1

Change in coreboot[master]: util/inteltool: Shrink buffer size

[Martin Roth (Code Review)]

Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33944 )

Change subject: util/inteltool: Shrink buffer size
......................................................................

util/inteltool: Shrink buffer size

512 bytes is much too big for this buffer, which only needs to hold a
path that will have a length of at most 20. The large buffer size also
triggers a -Wformat-truncation warning with GCC since it is later
printed into the smaller temp_string array, so shrink it down to
something reasonable.

Change-Id: I6a136d1a739c782b368d5035db9bc25cf5b9599b
Signed-off-by: Jacob Garber 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/33944
Tested-by: build bot (Jenkins) 
Reviewed-by: HAOUAS Elyes 
Reviewed-by: David Hendricks 
Reviewed-by: Paul Menzel 
---
M util/inteltool/cpu.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  David Hendricks: Looks good to me, approved
  Paul Menzel: Looks good to me, but someone else must approve
  HAOUAS Elyes: Looks good to me, but someone else must approve

diff --git a/util/inteltool/cpu.c b/util/inteltool/cpu.c
index ff69b8c..d2c8ede 100644
--- a/util/inteltool/cpu.c
+++ b/util/inteltool/cpu.c
@@ -110,7 +110,7 @@

static int open_and_seek(int cpu, unsigned long msr, int mode, int *fd)
 {
-	char dev[512];
+	char dev[32];
    char temp_string[50];

snprintf(dev, sizeof(dev), "/dev/cpu/%d/msr", cpu);