Attention is currently required from: Iman Bingi, Martin L Roth, Julius Werner, Patrick Rudolph.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/23586 )
Change subject: payloads/cbui: Add new payload CBUI ......................................................................
Patch Set 59:
(51 comments)
File payloads/cbui/NuklearUI/NuklearDatePicker.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159873): https://review.coreboot.org/c/coreboot/+/23586/comment/c05b4315_34d53260 PS59, Line 36: case 6: /* fallthrough */ Prefer 'fallthrough;' over fallthrough comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159873): https://review.coreboot.org/c/coreboot/+/23586/comment/b7407fd5_94045bcd PS59, Line 37: case 9: /* fallthrough */ Prefer 'fallthrough;' over fallthrough comment
File payloads/cbui/NuklearUI/NuklearRW.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159873): https://review.coreboot.org/c/coreboot/+/23586/comment/6e1471f7_8abaff92 PS59, Line 289: static const char *titles[] = { "Hex-View", "Header", "Index/Data" }; static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159873): https://review.coreboot.org/c/coreboot/+/23586/comment/0b4c8498_0da32eed PS59, Line 323: static const char *entries[] = { "NVRAM" }; static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwAcpi.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159873): https://review.coreboot.org/c/coreboot/+/23586/comment/6171bae5_cd71f8c4 PS59, Line 40: static const char *tools[] = { lang_translate(LANG_SAVE, 0), lang_translate( static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159873): https://review.coreboot.org/c/coreboot/+/23586/comment/4b9e6061_4f481ed0 PS59, Line 43: static const char *tabs[] = { "RSDP", "XSDT", "RSDT", "FACP", "HPET", "APIC", "MCFG", static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwAtaAtapi.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159873): https://review.coreboot.org/c/coreboot/+/23586/comment/3e76a3a3_5c8bd746 PS59, Line 23: static const char *tools[] = { lang_translate(LANG_SAVE, 0), lang_translate( static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159873): https://review.coreboot.org/c/coreboot/+/23586/comment/ed572c8f_e2e133ba PS59, Line 26: static const char *tabs[] = { "Hex-View", "Info", "Summary" }; static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwClock.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159873): https://review.coreboot.org/c/coreboot/+/23586/comment/4cae79b0_87b3ed29 PS59, Line 53: static const char *tools[] = { lang_translate(LANG_SAVE, 0), "Save bin", "Load", static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159873): https://review.coreboot.org/c/coreboot/+/23586/comment/74455591_2489bb87 PS59, Line 56: static const char *tabs[] = { "Hex-View", "Info", "Text" }; static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwCpuMsr.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159873): https://review.coreboot.org/c/coreboot/+/23586/comment/ca2a5029_456db4d2 PS59, Line 20: static const char *tools[] = { lang_translate(LANG_SAVE, 0) }; static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159873): https://review.coreboot.org/c/coreboot/+/23586/comment/c309e8c3_b4c0647f PS59, Line 22: static const char *tabs[] = { "MTRR", "User", "Summary" }; static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwDimmSpd.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159873): https://review.coreboot.org/c/coreboot/+/23586/comment/0dd1cb5f_35cf94d7 PS59, Line 61: static const char *tools[] = { lang_translate(LANG_SAVE, 0), "Save all", "Save bin", static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159873): https://review.coreboot.org/c/coreboot/+/23586/comment/8699d551_220dc6d2 PS59, Line 65: static const char *tabs[] = { "Hex-View", "Info", "Text", "Summary" }; static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwE820.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159873): https://review.coreboot.org/c/coreboot/+/23586/comment/1cffc5d9_50eb8cbd PS59, Line 20: static const char *tools[] = { lang_translate(LANG_SAVE, 0) }; static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwEc.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159873): https://review.coreboot.org/c/coreboot/+/23586/comment/3f65ae0b_252b6367 PS59, Line 49: static const char *tools[] = { lang_translate(LANG_SAVE, 0), "Save bin", "Load", static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159873): https://review.coreboot.org/c/coreboot/+/23586/comment/a39c032c_5f5cf6bf PS59, Line 52: static const char *tabs[] = { "Hex-View", "Info", "Text" }; static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwIo.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159873): https://review.coreboot.org/c/coreboot/+/23586/comment/4d5b8638_e103acdb PS59, Line 49: static const char *tools[] = { lang_translate(LANG_SAVE, 0), "Save bin", "Load", static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159873): https://review.coreboot.org/c/coreboot/+/23586/comment/3c8a9bd6_e8268854 PS59, Line 52: static const char *tabs[] = { "Hex-View", "Info", "Text" }; static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwIoIndexData.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159873): https://review.coreboot.org/c/coreboot/+/23586/comment/c7aa91a0_78cb860a PS59, Line 49: static const char *tools[] = { lang_translate(LANG_SAVE, 0), "Save bin", "Load", static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159873): https://review.coreboot.org/c/coreboot/+/23586/comment/874073c8_d2684f45 PS59, Line 52: static const char *tabs[] = { "Hex-View", "Info", "Text" }; static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwMemory.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159873): https://review.coreboot.org/c/coreboot/+/23586/comment/eac83b1f_e10422eb PS59, Line 53: static const char *tools[] = { lang_translate(LANG_SAVE, 0), "Save bin", "Load", static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159873): https://review.coreboot.org/c/coreboot/+/23586/comment/014137a9_058afe92 PS59, Line 56: static const char *tabs[] = { "Hex-View", "Info", "Text" }; static const char * array should probably be static const char * const
File payloads/cbui/arch/x86/int32.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159873): https://review.coreboot.org/c/coreboot/+/23586/comment/3479a845_cb2d41ef PS59, Line 20: typedef struct __attribute__ ((packed)) { Prefer __packed over __attribute__((packed))
File payloads/cbui/arch/x86/int32.nasm:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159873): https://review.coreboot.org/c/coreboot/+/23586/comment/df31c122_e358acb8 PS59, Line 38: struc regs16_t 'struc' may be misspelled - perhaps 'struct'?
File payloads/cbui/gfx/vbe.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159873): https://review.coreboot.org/c/coreboot/+/23586/comment/6163bec1_763b227d PS59, Line 24: static u8 low_mem[0x1000] __attribute__ ((section(".lowmem"))); Prefer __section(".lowmem") over __attribute__((section(".lowmem")))
File payloads/cbui/lang/de.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159873): https://review.coreboot.org/c/coreboot/+/23586/comment/73dc7d12_c9051af9 PS59, Line 39: "Kein Framebuffer gefunden. CBUI funktioniert nicht" \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159873): https://review.coreboot.org/c/coreboot/+/23586/comment/abb35624_59adce98 PS59, Line 44: "Der coreboot framebuffer hat keine physikalische " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159873): https://review.coreboot.org/c/coreboot/+/23586/comment/7d03f66c_a63afef3 PS59, Line 47: "Kein Platz auf dem Heap.\nBitte vergroBere den" \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159873): https://review.coreboot.org/c/coreboot/+/23586/comment/bf6ff546_663c7e06 PS59, Line 50: "Konnte die nuklear Bibliothek nicht intitialisieren.\nBitte" \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159873): https://review.coreboot.org/c/coreboot/+/23586/comment/358ebb88_d703f4fb PS59, Line 52: "stelle sicher, das der Framebuffer entweder das RGBX8 oder " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159873): https://review.coreboot.org/c/coreboot/+/23586/comment/b2dc3c3b_24c3e069 PS59, Line 65: "Fehler: Keine CMOS Eintrage gefunden. Bitte schalte die " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159873): https://review.coreboot.org/c/coreboot/+/23586/comment/2d6016ce_fb4a41c2 PS59, Line 86: "Fehler: Keine Zeitstempel gefunden. Bitte schalte die " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159873): https://review.coreboot.org/c/coreboot/+/23586/comment/7804d4d8_0b47472b PS59, Line 89: "Fehler: Bootlog nicht gefunden. Bitte schalte die Kconfig " \ Avoid unnecessary line continuations
File payloads/cbui/lang/en.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159873): https://review.coreboot.org/c/coreboot/+/23586/comment/ffda0c1c_5467924c PS59, Line 38: "No framebuffer found. CBUI doesn't work in text mode.\n" \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159873): https://review.coreboot.org/c/coreboot/+/23586/comment/7f613091_07065003 PS59, Line 46: "Failed to init nuklear library.\nMake sure you have enough " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159873): https://review.coreboot.org/c/coreboot/+/23586/comment/f23d184f_aab311b9 PS59, Line 60: "ERROR: No CMOS options found. Please make sure to enable " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159873): https://review.coreboot.org/c/coreboot/+/23586/comment/d4646581_becedb3d PS59, Line 81: "ERROR: No timestamps found. Please make sure to enable " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159873): https://review.coreboot.org/c/coreboot/+/23586/comment/8ab4e74a_98e56a50 PS59, Line 84: "ERROR: Bootlog not found. Please make sure to enable " \ Avoid unnecessary line continuations
File payloads/cbui/modules/bootlog_module.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159873): https://review.coreboot.org/c/coreboot/+/23586/comment/46ef578d_98be5831 PS59, Line 28: } __attribute__ ((__packed__)); Prefer __packed over __attribute__((__packed__))
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159873): https://review.coreboot.org/c/coreboot/+/23586/comment/bce227ec_00308d4f PS59, Line 82: } void function return statements are not generally useful
File payloads/cbui/modules/cbfs_module.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159873): https://review.coreboot.org/c/coreboot/+/23586/comment/970bc8bf_ad511cde PS59, Line 50: } __attribute__ ((packed)); Prefer __packed over __attribute__((packed))
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159873): https://review.coreboot.org/c/coreboot/+/23586/comment/d32d8d9f_6189773b PS59, Line 59: } __attribute__ ((packed)); Prefer __packed over __attribute__((packed))
File payloads/cbui/modules/cpuinfo_module.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159873): https://review.coreboot.org/c/coreboot/+/23586/comment/52cb3bbc_343ca12a PS59, Line 35: static const char *intel_cap_edx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159873): https://review.coreboot.org/c/coreboot/+/23586/comment/8be0953a_37f0f41a PS59, Line 43: static const char *amd_cap_edx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159873): https://review.coreboot.org/c/coreboot/+/23586/comment/84ca2a79_09a5af1c PS59, Line 51: static const char *intel_cap_ecx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159873): https://review.coreboot.org/c/coreboot/+/23586/comment/a84fd476_51cfcee2 PS59, Line 59: static const char *amd_cap_ecx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159873): https://review.coreboot.org/c/coreboot/+/23586/comment/0e774d9d_6945ab33 PS59, Line 67: static const char *intel_cap_extended_edx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159873): https://review.coreboot.org/c/coreboot/+/23586/comment/3b3fb076_c6621501 PS59, Line 75: static const char *intel_cap_extended_ecx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159873): https://review.coreboot.org/c/coreboot/+/23586/comment/6be6b74f_56a9d7cb PS59, Line 83: static const char *amd_cap_extended_edx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159873): https://review.coreboot.org/c/coreboot/+/23586/comment/ef7d8160_9e7e325e PS59, Line 92: static const char *amd_cap_extended_ecx_flags[] = { static const char * array should probably be static const char * const
-
build bot (Jenkins) (Code Review)