[XL] Change in coreboot[main]: soc/intel/ptl: Do initial Panther Lake SoC commit till ramstage

[Subrata Banik (Code Review)]

Attention is currently required from: Jérémy Compostella, Kapil Porwal, Pranava Y N, Saurabh Mishra.

Subrata Banik has posted comments on this change by Saurabh Mishra. ( https://review.coreboot.org/c/coreboot/+/83798?usp=email )

Change subject: soc/intel/ptl: Do initial Panther Lake SoC commit till ramstage
......................................................................

Patch Set 75:

(5 comments)

File src/soc/intel/pantherlake/acpi.c:

https://review.coreboot.org/c/coreboot/+/83798/comment/2d28e10f_ee500cd4?usp... :
PS75, Line 126: 	/* Early return if the map is already initialized */
why we need this comment ? i mean what benefit one will get by looking into the comment as the code itself is self-explanatory

https://review.coreboot.org/c/coreboot/+/83798/comment/5541bcad_8edb8f6a?usp... :
PS75, Line 127:  {
single statement doesn't need a brace (https://doc.coreboot.org/contributing/coding_style.html#placing-braces-and-s...)

File src/soc/intel/pantherlake/include/soc/iomap.h:

https://review.coreboot.org/c/coreboot/+/83798/comment/a345b944_c7651b86?usp... :
PS75, Line 23: Dummy
`dummy`

File src/soc/intel/pantherlake/pmc.c:

https://review.coreboot.org/c/coreboot/+/83798/comment/1f04d6bb_f57826c2?usp... :
PS71, Line 29: reg
> Hi, you mean to implment a check in this function?

please ignore the comment

File src/soc/intel/pantherlake/pmc.c:

https://review.coreboot.org/c/coreboot/+/83798/comment/f1522b6b_bfed9136?usp... :
PS75, Line 25: pmcbase
ideally we need to check if `pmcbase` is not NULL