[XS] Change in coreboot[main]: ec/google/chromeec: Ensure pre-CR50 devices use "short" battery strings - coreboot-gerrit

12 Sep 2024


      Attention is currently required from: Matt DeVillier.
Peter Marheine has posted comments on this change by Matt DeVillier. ( https://review.coreboot.org/c/coreboot/+/84300?usp=email )
Change subject: ec/google/chromeec: Ensure pre-CR50 devices use "short" battery strings
......................................................................
Patch Set 2: Code-Review+1
(2 comments)
Patchset:
PS1:
...
verified patch set 2 on google/lulu
Acknowledged
File src/ec/google/chromeec/acpi/battery.asl:
https://review.coreboot.org/c/coreboot/+/84300/comment/3b0db33f_5c845c11?usp... :
PS1, Line 174: #if CONFIG(TPM_GOOGLE_CR50) || CONFIG(TPM_GOOGLE_TI50)
...
agreed, can do that once we agree that these guards are the least-worst way to work around the probl […]
Done
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/84300?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If3686dc9b82b44202947081ec7e253317deb8fff
Gerrit-Change-Number: 84300
Gerrit-PatchSet: 2
Gerrit-Owner: Matt DeVillier matt.devillier@gmail.com
Gerrit-Reviewer: Caveh Jalali caveh@chromium.org
Gerrit-Reviewer: Forest Mittelberg bmbm@google.com
Gerrit-Reviewer: Peter Marheine pmarheine@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Matt DeVillier matt.devillier@gmail.com
Gerrit-Comment-Date: Thu, 12 Sep 2024 23:43:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Matt DeVillier matt.devillier@gmail.com
Comment-In-Reply-To: Peter Marheine pmarheine@chromium.org