Attention is currently required from: Hung-Te Lin, Angel Pons, Jianjun Wang.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62933 )
Change subject: soc/mediatek: Add timestamp to measure PERST# time
......................................................................
Patch Set 1:
(2 comments)
File src/mainboard/google/cherry/bootblock.c:
https://review.coreboot.org/c/coreboot/+/62933/comment/dae39320_fad1d982
PS1, Line 56: write64
We should also add read/write API for this in pcie_common.h. For example,
void mtk_pcie_save_timestamp(uint64_t timestamp);
uint64_t mtk_pcie_load_timestamp(void);
File src/soc/mediatek/common/pcie.c:
https://review.coreboot.org/c/coreboot/+/62933/comment/1d06eeef_0b9b9b5f
PS1, Line 238: COLLECT_TIMESTAMPS
Since the 100ms delay is a requirement, should we always do this?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62933
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie2b7b6174abdf951af5796ab5ed141c45f32fc71
Gerrit-Change-Number: 62933
Gerrit-PatchSet: 1
Gerrit-Owner: Jianjun Wang
jianjun.wang@mediatek.corp-partner.google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Jianjun Wang
jianjun.wang@mediatek.corp-partner.google.com
Gerrit-Comment-Date: Mon, 21 Mar 2022 09:40:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment