Attention is currently required from: Paul Menzel, Nicholas Chin, Felix Held.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70623 )
Change subject: mb/acer: Add Acer Swift 3 (Intel Kaby Lake) ......................................................................
Patch Set 13:
(8 comments)
File src/mainboard/acer/swift3-SF314-52G-55WQ/bootblock.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-170568): https://review.coreboot.org/c/coreboot/+/70623/comment/7c7d9b59_13b334b6 PS13, Line 49: switch(combined) that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-170568): https://review.coreboot.org/c/coreboot/+/70623/comment/1da7ddf8_64830443 PS13, Line 49: switch(combined) space required before the open parenthesis '('
File src/mainboard/acer/swift3-SF314-52G-55WQ/devicetree.cb:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-170568): https://review.coreboot.org/c/coreboot/+/70623/comment/5e66abdc_73c369c6 PS13, Line 21: # size is calcualted: size = (0x3 | ((gen_io_dec >> 16) & 0xfc)) + 1; 'calcualted' may be misspelled - perhaps 'calculated'?
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-170568): https://review.coreboot.org/c/coreboot/+/70623/comment/47891b8c_009e0a56 PS13, Line 346: end trailing whitespace
File src/mainboard/acer/swift3-SF314-52G-55WQ/gpio_early.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-170568): https://review.coreboot.org/c/coreboot/+/70623/comment/9b51eeb6_d8742eef PS13, Line 7: * trailing whitespace
File src/mainboard/acer/swift3-SF314-52G-55WQ/mainboard.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-170568): https://review.coreboot.org/c/coreboot/+/70623/comment/7e270168_3e3f1742 PS13, Line 33: do that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-170568): https://review.coreboot.org/c/coreboot/+/70623/comment/fb6666d1_80668603 PS13, Line 35: tpm_resp = *(uint32_t*)(0xFED40000); "(foo*)" should be "(foo *)"
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-170568): https://review.coreboot.org/c/coreboot/+/70623/comment/f6f1f892_52564210 PS13, Line 42: if ( (tpm_b & 0x80) == 0x80) { space prohibited after that open parenthesis '('
-
build bot (Jenkins) (Code Review)