Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45423 )
Change subject: nb/intel/pineview: Drop unused `GPIO32` macro ......................................................................
nb/intel/pineview: Drop unused `GPIO32` macro
It's not used, and GPIO registers are on the southbridge.
Change-Id: I0b7b6edc22d461007f24618eca42091439a53d3c Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/northbridge/intel/pineview/pineview.h 1 file changed, 0 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/45423/1
diff --git a/src/northbridge/intel/pineview/pineview.h b/src/northbridge/intel/pineview/pineview.h index 82ae3ff..48ee263 100644 --- a/src/northbridge/intel/pineview/pineview.h +++ b/src/northbridge/intel/pineview/pineview.h @@ -26,8 +26,6 @@ #define GTTADR 0x1c #define BSM 0x5c
-#define GPIO32(x) *((volatile u32 *)(DEFAULT_GPIOBASE + x)) - /* * MCHBAR */
Attention is currently required from: Nico Huber, Christian Walter, Tim Wawrzynczak, Angel Pons. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45423 )
Change subject: nb/intel/pineview: Drop unused `GPIO32` macro ......................................................................
Patch Set 3: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45423 )
Change subject: nb/intel/pineview: Drop unused `GPIO32` macro ......................................................................
nb/intel/pineview: Drop unused `GPIO32` macro
It's not used, and GPIO registers are on the southbridge.
Change-Id: I0b7b6edc22d461007f24618eca42091439a53d3c Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/45423 Reviewed-by: Arthur Heymans arthur@aheymans.xyz Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/northbridge/intel/pineview/pineview.h 1 file changed, 0 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Arthur Heymans: Looks good to me, approved
diff --git a/src/northbridge/intel/pineview/pineview.h b/src/northbridge/intel/pineview/pineview.h index 914c3a3..f2ae1c4 100644 --- a/src/northbridge/intel/pineview/pineview.h +++ b/src/northbridge/intel/pineview/pineview.h @@ -27,8 +27,6 @@ #define GTTADR 0x1c #define BSM 0x5c
-#define GPIO32(x) *((volatile u32 *)(DEFAULT_GPIOBASE + x)) - /* * MCHBAR */
-
Angel Pons (Code Review) -
Arthur Heymans (Code Review)
-
Patrick Georgi (Code Review)