[M] Change in coreboot[master]: mb/google/skyrim: Add named GPIO's - coreboot-gerrit

22 Apr 2023


      Attention is currently required from: Raul Rangel, Jason Nien, Jon Murphy, Martin Roth, Tim Van Patten, Mark Hasemeyer.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74607 )
Change subject: mb/google/skyrim: Add named GPIO's
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/skyrim/port_descriptors.c:
https://review.coreboot.org/c/coreboot/+/74607/comment/b9513c33_ae17d56b 
PS1, Line 3: #include <variant/gpio.h>
...
Has to be before soc/platform_descriptors. […]
Not sure why include order matters. Ideally it should not be.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/74607
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I24a8f7e5bfa9e3e586d4189132f47551202f7d2d
Gerrit-Change-Number: 74607
Gerrit-PatchSet: 1
Gerrit-Owner: Jon Murphy jpmurphy@google.com
Gerrit-Reviewer: Jason Nien jason.nien@amd.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: Mark Hasemeyer markhas@google.com
Gerrit-Reviewer: Martin Roth martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: Tim Van Patten timvp@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Raul Rangel rrangel@chromium.org
Gerrit-Attention: Jason Nien jason.nien@amd.corp-partner.google.com
Gerrit-Attention: Jon Murphy jpmurphy@google.com
Gerrit-Attention: Martin Roth martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Tim Van Patten timvp@google.com
Gerrit-Attention: Mark Hasemeyer markhas@google.com
Gerrit-Comment-Date: Fri, 21 Apr 2023 23:24:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jon Murphy jpmurphy@google.com
Gerrit-MessageType: comment