Change in coreboot[master]: vc/amd/fsp/picasso: add FSP-M UPD to disable the SATA controller

[Felix Held (Code Review)]

Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44256 )

Change subject: vc/amd/fsp/picasso: add FSP-M UPD to disable the SATA controller
......................................................................

vc/amd/fsp/picasso: add FSP-M UPD to disable the SATA controller

BUG=b:162302027

Change-Id: Iff9a09cb59fdc16be8b4ea41303704166a97172e
Signed-off-by: Felix Held 
---
M src/vendorcode/amd/fsp/picasso/FspmUpd.h
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/44256/1

diff --git a/src/vendorcode/amd/fsp/picasso/FspmUpd.h b/src/vendorcode/amd/fsp/picasso/FspmUpd.h
index c1766e8..63cc4ae 100644
--- a/src/vendorcode/amd/fsp/picasso/FspmUpd.h
+++ b/src/vendorcode/amd/fsp/picasso/FspmUpd.h
@@ -58,7 +58,7 @@
    /** Offset 0x00C8**/	uint32_t                    tseg_size;
    /** Offset 0x00CC**/	uint8_t                     pspp_policy;
    /** Offset 0x00CD**/	uint8_t                     audio_soundwire;
-	/** Offset 0x00CE**/	uint8_t                     unused8;
+	/** Offset 0x00CE**/	uint8_t                     sata_disable;
    /** Offset 0x00CF**/	uint8_t                     unused9;
    /** Offset 0x00D0**/	uint32_t                    bert_size;
    /** Offset 0x00D4**/	uint8_t                     UnusedUpdSpace0;

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44256 )

Change subject: vc/amd/fsp/picasso: add FSP-M UPD to disable the SATA controller
......................................................................

Patch Set 1: Code-Review+2

[Aaron Durbin (Code Review)]

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44256 )

Change subject: vc/amd/fsp/picasso: add FSP-M UPD to disable the SATA controller
......................................................................

Patch Set 1: Code-Review+2

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44256 )

Change subject: vc/amd/fsp/picasso: add FSP-M UPD to disable the SATA controller
......................................................................

Patch Set 1: Code-Review+2

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44256 )

Change subject: vc/amd/fsp/picasso: add FSP-M UPD to disable the SATA controller
......................................................................

vc/amd/fsp/picasso: add FSP-M UPD to disable the SATA controller

BUG=b:162302027

Change-Id: Iff9a09cb59fdc16be8b4ea41303704166a97172e
Signed-off-by: Felix Held 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/44256
Tested-by: build bot (Jenkins) 
Reviewed-by: Angel Pons 
Reviewed-by: Aaron Durbin 
Reviewed-by: Furquan Shaikh 
---
M src/vendorcode/amd/fsp/picasso/FspmUpd.h
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Aaron Durbin: Looks good to me, approved
  Furquan Shaikh: Looks good to me, approved
  Angel Pons: Looks good to me, approved

diff --git a/src/vendorcode/amd/fsp/picasso/FspmUpd.h b/src/vendorcode/amd/fsp/picasso/FspmUpd.h
index c1766e8..63cc4ae 100644
--- a/src/vendorcode/amd/fsp/picasso/FspmUpd.h
+++ b/src/vendorcode/amd/fsp/picasso/FspmUpd.h
@@ -58,7 +58,7 @@
    /** Offset 0x00C8**/	uint32_t                    tseg_size;
    /** Offset 0x00CC**/	uint8_t                     pspp_policy;
    /** Offset 0x00CD**/	uint8_t                     audio_soundwire;
-	/** Offset 0x00CE**/	uint8_t                     unused8;
+	/** Offset 0x00CE**/	uint8_t                     sata_disable;
    /** Offset 0x00CF**/	uint8_t                     unused9;
    /** Offset 0x00D0**/	uint32_t                    bert_size;
    /** Offset 0x00D4**/	uint8_t                     UnusedUpdSpace0;

[Felix Held (Code Review)]

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44256 )

Change subject: vc/amd/fsp/picasso: add FSP-M UPD to disable the SATA controller
......................................................................

Patch Set 2:

this shouldn't have been merged yet, since the FSP part isn't sorted out yet and was moved around. i'll prepare a revert

[Aaron Durbin (Code Review)]

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44256 )

Change subject: vc/amd/fsp/picasso: add FSP-M UPD to disable the SATA controller
......................................................................

Patch Set 2:
> Patch Set 2:
>
> this shouldn't have been merged yet, since the FSP part isn't sorted out yet and was moved around. i'll prepare a revert

This change is just exposing a field.

[Felix Held (Code Review)]

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44256 )

Change subject: vc/amd/fsp/picasso: add FSP-M UPD to disable the SATA controller
......................................................................

Patch Set 2:
> Patch Set 2:
> > Patch Set 2:
> >
> > this shouldn't have been merged yet, since the FSP part isn't sorted out yet and was moved around. i'll prepare a revert
>
> This change is just exposing a field.

yeah, i doesn't cause any malfunction, but i still didn't plan to submit it before both patch trains on both sides are verified to work

[Felix Held (Code Review)]

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44256 )

Change subject: vc/amd/fsp/picasso: add FSP-M UPD to disable the SATA controller
......................................................................

Patch Set 2:
> yeah, i doesn't cause any malfunction, but i still didn't plan to submit it before both patch trains on both sides are verified to work

*it