Attention is currently required from: Angel Pons, Patrick Rudolph.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61517 )
Change subject: [WIP]aopen/dxplplusu: Enable SMM_ASEG ......................................................................
Patch Set 2:
(64 comments)
File src/southbridge/intel/i82801dx/smihandler.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162881): https://review.coreboot.org/c/coreboot/+/61517/comment/77c0be38_07eb418e PS2, Line 45: if (pm1_sts & (1 << 15)) printk(BIOS_SPEW, "WAK "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162881): https://review.coreboot.org/c/coreboot/+/61517/comment/c0155082_5dbb17a3 PS2, Line 46: if (pm1_sts & (1 << 14)) printk(BIOS_SPEW, "PCIEXPWAK "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162881): https://review.coreboot.org/c/coreboot/+/61517/comment/95f18ad7_301f89fa PS2, Line 47: if (pm1_sts & (1 << 11)) printk(BIOS_SPEW, "PRBTNOR "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162881): https://review.coreboot.org/c/coreboot/+/61517/comment/29b13ce3_2a36782d PS2, Line 48: if (pm1_sts & (1 << 10)) printk(BIOS_SPEW, "RTC "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162881): https://review.coreboot.org/c/coreboot/+/61517/comment/e64f18b2_0003f7d4 PS2, Line 49: if (pm1_sts & (1 << 8)) printk(BIOS_SPEW, "PWRBTN "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162881): https://review.coreboot.org/c/coreboot/+/61517/comment/1cec1027_2982a547 PS2, Line 50: if (pm1_sts & (1 << 5)) printk(BIOS_SPEW, "GBL "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162881): https://review.coreboot.org/c/coreboot/+/61517/comment/f6ad8e3c_355f2ce4 PS2, Line 51: if (pm1_sts & (1 << 4)) printk(BIOS_SPEW, "BM "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162881): https://review.coreboot.org/c/coreboot/+/61517/comment/28be476b_40605e5e PS2, Line 52: if (pm1_sts & (1 << 0)) printk(BIOS_SPEW, "TMROF "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162881): https://review.coreboot.org/c/coreboot/+/61517/comment/6a9eea6c_c51b1dc7 PS2, Line 76: if (smi_sts & (1 << 26)) printk(BIOS_DEBUG, "SPI "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162881): https://review.coreboot.org/c/coreboot/+/61517/comment/ac97a029_624e769a PS2, Line 77: if (smi_sts & (1 << 25)) printk(BIOS_DEBUG, "EL_SMI "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162881): https://review.coreboot.org/c/coreboot/+/61517/comment/950b3ab4_f4bb74e5 PS2, Line 78: if (smi_sts & (1 << 21)) printk(BIOS_DEBUG, "MONITOR "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162881): https://review.coreboot.org/c/coreboot/+/61517/comment/b3a77a19_7117ccee PS2, Line 79: if (smi_sts & (1 << 20)) printk(BIOS_DEBUG, "PCI_EXP_SMI "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162881): https://review.coreboot.org/c/coreboot/+/61517/comment/8e81da42_0aba544a PS2, Line 80: if (smi_sts & (1 << 18)) printk(BIOS_DEBUG, "INTEL_USB2 "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162881): https://review.coreboot.org/c/coreboot/+/61517/comment/d6be71fa_9b7ff4a3 PS2, Line 81: if (smi_sts & (1 << 17)) printk(BIOS_DEBUG, "LEGACY_USB2 "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162881): https://review.coreboot.org/c/coreboot/+/61517/comment/32df225b_08cdc24b PS2, Line 82: if (smi_sts & (1 << 16)) printk(BIOS_DEBUG, "SMBUS_SMI "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162881): https://review.coreboot.org/c/coreboot/+/61517/comment/a31de866_85d1eb90 PS2, Line 83: if (smi_sts & (1 << 15)) printk(BIOS_DEBUG, "SERIRQ_SMI "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162881): https://review.coreboot.org/c/coreboot/+/61517/comment/4ed9462a_c573237d PS2, Line 84: if (smi_sts & (1 << 14)) printk(BIOS_DEBUG, "PERIODIC "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162881): https://review.coreboot.org/c/coreboot/+/61517/comment/6d653ff0_848235ee PS2, Line 85: if (smi_sts & (1 << 13)) printk(BIOS_DEBUG, "TCO "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162881): https://review.coreboot.org/c/coreboot/+/61517/comment/3636599f_21acd656 PS2, Line 86: if (smi_sts & (1 << 12)) printk(BIOS_DEBUG, "DEVMON "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162881): https://review.coreboot.org/c/coreboot/+/61517/comment/6eae9070_c96dab7c PS2, Line 87: if (smi_sts & (1 << 11)) printk(BIOS_DEBUG, "MCSMI "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162881): https://review.coreboot.org/c/coreboot/+/61517/comment/7e312524_70a723e1 PS2, Line 88: if (smi_sts & (1 << 10)) printk(BIOS_DEBUG, "GPI "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162881): https://review.coreboot.org/c/coreboot/+/61517/comment/d56d0eae_2c0379a7 PS2, Line 89: if (smi_sts & (1 << 9)) printk(BIOS_DEBUG, "GPE0 "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162881): https://review.coreboot.org/c/coreboot/+/61517/comment/1a0ec7d1_c035d36c PS2, Line 90: if (smi_sts & (1 << 8)) printk(BIOS_DEBUG, "PM1 "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162881): https://review.coreboot.org/c/coreboot/+/61517/comment/74b8d478_aa4f77cd PS2, Line 91: if (smi_sts & (1 << 6)) printk(BIOS_DEBUG, "SWSMI_TMR "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162881): https://review.coreboot.org/c/coreboot/+/61517/comment/025e8dc2_01668b31 PS2, Line 92: if (smi_sts & (1 << 5)) printk(BIOS_DEBUG, "APM "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162881): https://review.coreboot.org/c/coreboot/+/61517/comment/da488070_6f139912 PS2, Line 93: if (smi_sts & (1 << 4)) printk(BIOS_DEBUG, "SLP_SMI "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162881): https://review.coreboot.org/c/coreboot/+/61517/comment/e869a820_9d991958 PS2, Line 94: if (smi_sts & (1 << 3)) printk(BIOS_DEBUG, "LEGACY_USB "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162881): https://review.coreboot.org/c/coreboot/+/61517/comment/f58b3b38_4d9a8737 PS2, Line 95: if (smi_sts & (1 << 2)) printk(BIOS_DEBUG, "BIOS "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162881): https://review.coreboot.org/c/coreboot/+/61517/comment/fd49b890_391a7f39 PS2, Line 118: for (i=31; i>= 16; i--) { spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162881): https://review.coreboot.org/c/coreboot/+/61517/comment/9ed90c81_a74789e2 PS2, Line 118: for (i=31; i>= 16; i--) { spaces required around that '>=' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162881): https://review.coreboot.org/c/coreboot/+/61517/comment/3addc6c8_4f0e42dc PS2, Line 119: if (gpe0_sts & (1 << i)) printk(BIOS_DEBUG, "GPIO%d ", (i-16)); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162881): https://review.coreboot.org/c/coreboot/+/61517/comment/aa57f84e_3832434e PS2, Line 121: if (gpe0_sts & (1 << 14)) printk(BIOS_DEBUG, "USB4 "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162881): https://review.coreboot.org/c/coreboot/+/61517/comment/9a7eecbd_65891185 PS2, Line 122: if (gpe0_sts & (1 << 13)) printk(BIOS_DEBUG, "PME_B0 "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162881): https://review.coreboot.org/c/coreboot/+/61517/comment/c93aecee_dde2067e PS2, Line 123: if (gpe0_sts & (1 << 12)) printk(BIOS_DEBUG, "USB3 "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162881): https://review.coreboot.org/c/coreboot/+/61517/comment/edc8b98a_80e66b75 PS2, Line 124: if (gpe0_sts & (1 << 11)) printk(BIOS_DEBUG, "PME "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162881): https://review.coreboot.org/c/coreboot/+/61517/comment/d4ef0d79_b273515f PS2, Line 125: if (gpe0_sts & (1 << 10)) printk(BIOS_DEBUG, "EL_SCI/BATLOW "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162881): https://review.coreboot.org/c/coreboot/+/61517/comment/a5c6700a_5c3795a4 PS2, Line 126: if (gpe0_sts & (1 << 9)) printk(BIOS_DEBUG, "PCI_EXP "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162881): https://review.coreboot.org/c/coreboot/+/61517/comment/038eab4f_9ee21529 PS2, Line 127: if (gpe0_sts & (1 << 8)) printk(BIOS_DEBUG, "RI "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162881): https://review.coreboot.org/c/coreboot/+/61517/comment/f75e0c15_041cbe1e PS2, Line 128: if (gpe0_sts & (1 << 7)) printk(BIOS_DEBUG, "SMB_WAK "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162881): https://review.coreboot.org/c/coreboot/+/61517/comment/85585502_f2c1f0d8 PS2, Line 129: if (gpe0_sts & (1 << 6)) printk(BIOS_DEBUG, "TCO_SCI "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162881): https://review.coreboot.org/c/coreboot/+/61517/comment/1832cbd8_0735f1ed PS2, Line 130: if (gpe0_sts & (1 << 5)) printk(BIOS_DEBUG, "AC97 "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162881): https://review.coreboot.org/c/coreboot/+/61517/comment/dc0ba6a3_d989c63c PS2, Line 131: if (gpe0_sts & (1 << 4)) printk(BIOS_DEBUG, "USB2 "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162881): https://review.coreboot.org/c/coreboot/+/61517/comment/da75d6e1_9ceb599a PS2, Line 132: if (gpe0_sts & (1 << 3)) printk(BIOS_DEBUG, "USB1 "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162881): https://review.coreboot.org/c/coreboot/+/61517/comment/58bdbaa5_8414b041 PS2, Line 133: if (gpe0_sts & (1 << 2)) printk(BIOS_DEBUG, "HOT_PLUG "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162881): https://review.coreboot.org/c/coreboot/+/61517/comment/54487ad3_f5608ffe PS2, Line 134: if (gpe0_sts & (1 << 0)) printk(BIOS_DEBUG, "THRM "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162881): https://review.coreboot.org/c/coreboot/+/61517/comment/79419211_2c059649 PS2, Line 159: if (tco_sts & (1 << 20)) printk(BIOS_DEBUG, "SMLINK_SLV "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162881): https://review.coreboot.org/c/coreboot/+/61517/comment/a61a2200_b732b2ef PS2, Line 160: if (tco_sts & (1 << 18)) printk(BIOS_DEBUG, "BOOT "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162881): https://review.coreboot.org/c/coreboot/+/61517/comment/ea085342_1dd582cb PS2, Line 161: if (tco_sts & (1 << 17)) printk(BIOS_DEBUG, "SECOND_TO "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162881): https://review.coreboot.org/c/coreboot/+/61517/comment/efa4fb63_d59fa28b PS2, Line 162: if (tco_sts & (1 << 16)) printk(BIOS_DEBUG, "INTRD_DET "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162881): https://review.coreboot.org/c/coreboot/+/61517/comment/9d12ec0a_4bd5ad60 PS2, Line 163: if (tco_sts & (1 << 12)) printk(BIOS_DEBUG, "DMISERR "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162881): https://review.coreboot.org/c/coreboot/+/61517/comment/0dc3e24a_059c62c5 PS2, Line 164: if (tco_sts & (1 << 10)) printk(BIOS_DEBUG, "DMISMI "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162881): https://review.coreboot.org/c/coreboot/+/61517/comment/452f8229_89ff51f5 PS2, Line 165: if (tco_sts & (1 << 9)) printk(BIOS_DEBUG, "DMISCI "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162881): https://review.coreboot.org/c/coreboot/+/61517/comment/22d63f29_f4ed9f49 PS2, Line 166: if (tco_sts & (1 << 8)) printk(BIOS_DEBUG, "BIOSWR "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162881): https://review.coreboot.org/c/coreboot/+/61517/comment/c97147b1_71a67ce5 PS2, Line 167: if (tco_sts & (1 << 7)) printk(BIOS_DEBUG, "NEWCENTURY "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162881): https://review.coreboot.org/c/coreboot/+/61517/comment/01e77c88_d2a704f9 PS2, Line 168: if (tco_sts & (1 << 3)) printk(BIOS_DEBUG, "TIMEOUT "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162881): https://review.coreboot.org/c/coreboot/+/61517/comment/5254419c_6efc7870 PS2, Line 169: if (tco_sts & (1 << 2)) printk(BIOS_DEBUG, "TCO_INT "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162881): https://review.coreboot.org/c/coreboot/+/61517/comment/9e235c08_57b66168 PS2, Line 170: if (tco_sts & (1 << 1)) printk(BIOS_DEBUG, "SW_TCO "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162881): https://review.coreboot.org/c/coreboot/+/61517/comment/2d800e49_296176f8 PS2, Line 171: if (tco_sts & (1 << 0)) printk(BIOS_DEBUG, "NMI2SMI "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162881): https://review.coreboot.org/c/coreboot/+/61517/comment/450ec3a5_59f0eed9 PS2, Line 247: case ACPI_S0: printk(BIOS_DEBUG, "SMI#: Entering S0 (On)\n"); break; trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162881): https://review.coreboot.org/c/coreboot/+/61517/comment/1c91ae44_48dc2fc5 PS2, Line 248: case ACPI_S1: printk(BIOS_DEBUG, "SMI#: Entering S1 (Assert STPCLK#)\n"); break; trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162881): https://review.coreboot.org/c/coreboot/+/61517/comment/9ce2c85a_c688d0af PS2, Line 254: case ACPI_S4: printk(BIOS_DEBUG, "SMI#: Entering S4 (Suspend-To-Disk)\n"); break; trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162881): https://review.coreboot.org/c/coreboot/+/61517/comment/c51da23b_30a933df PS2, Line 274: default: printk(BIOS_DEBUG, "SMI#: ERROR: SLP_TYP reserved\n"); break; trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162881): https://review.coreboot.org/c/coreboot/+/61517/comment/72f6f1a3_93d98989 PS2, Line 352: printk(BIOS_DEBUG, "GPI (mask %04x)\n",reg16); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162881): https://review.coreboot.org/c/coreboot/+/61517/comment/e464b926_9966852b PS2, Line 488: if (dump) { braces {} are not necessary for single statement blocks
-
build bot (Jenkins) (Code Review)