Attention is currently required from: Hung-Te Lin, Kiwi Liu, Mengqi Zhang, Yu-Ping Wu.
Paul Menzel has posted comments on this change by Kiwi Liu. ( https://review.coreboot.org/c/coreboot/+/84298?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: soc/mediatek/common: Fix eMMC clock
......................................................................
Patch Set 9:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84298/comment/619bcf15_22cbce90?usp... :
PS9, Line 13: measure eMMC clock ok
:
Did you measure with an oscilloscope? What did it show exactly?
File src/soc/mediatek/common/msdc.c:
https://review.coreboot.org/c/coreboot/+/84298/comment/694caf5c_c88c02ca?usp... :
PS9, Line 432: host->src_hz = 400 * 1000 * 1000;
Add a comment, that it’s supposed to result in 400 kHz eMMC clock? From the values here, it would be 400 MHz, wouldn’t it?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84298?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I9c8836b23fb21e9b0bdc80fbe85142ea0fa5e381
Gerrit-Change-Number: 84298
Gerrit-PatchSet: 9
Gerrit-Owner: Kiwi Liu
kiwi.liu@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Mengqi Zhang
mengqi.zhang@mediatek.corp-partner.google.com
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Kiwi Liu
kiwi.liu@mediatek.corp-partner.google.com
Gerrit-Attention: Mengqi Zhang
mengqi.zhang@mediatek.corp-partner.google.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Thu, 12 Sep 2024 06:44:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No