Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/85208?usp=email )
Change subject: soc/intel/cmn/acpi: Use Kconfig guards for UFS workarounds ......................................................................
soc/intel/cmn/acpi: Use Kconfig guards for UFS workarounds
This change introduces Kconfig guards around the UFS workaround code in the common ACPI ASL file. This ensures that these workarounds are only applied when necessary, allowing future SoCs with UFS controllers to reuse the common ASL file without modification.
By using Kconfig, we can enable or disable the workarounds based on the specific SoC configuration, providing greater flexibility and maintainability.
BUG=b:379828045 TEST=Able to compile google/fatcat.
Change-Id: I968b8811e508378a36648bd8234ff0fd7237b00d Signed-off-by: Subrata Banik subratabanik@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/85208 Reviewed-by: Pranava Y N pranavayn@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/intel/common/block/acpi/acpi/ufs.asl 1 file changed, 4 insertions(+), 0 deletions(-)
Approvals: Pranava Y N: Looks good to me, approved build bot (Jenkins): Verified
diff --git a/src/soc/intel/common/block/acpi/acpi/ufs.asl b/src/soc/intel/common/block/acpi/acpi/ufs.asl index fcfe9bd..7d8d25d 100644 --- a/src/soc/intel/common/block/acpi/acpi/ufs.asl +++ b/src/soc/intel/common/block/acpi/acpi/ufs.asl @@ -28,6 +28,7 @@ } })
+#if CONFIG(SOC_INTEL_UFS_OCP_TIMER_DISABLE) /* * OCP Timer need to be disabled in SCS UFS IOSF Bridge to work around * the Silicon Issue due to which LTR mechanism doesn't work. @@ -47,6 +48,7 @@ PCRA (PID_UFSX2, R_SCS_PCR_5820, 0x0) PCRA (PID_UFSX2, R_SCS_PCR_1078, 0x0) } +#endif
/* Memory Region to access to the UFS PCI Configuration Space */ OperationRegion(SCSR, PCI_Config, 0x00, 0x100) @@ -62,6 +64,7 @@ PGEN, 1 }
+#if CONFIG(SOC_INTEL_UFS_LTR_DISQUALIFY) OperationRegion(PWMR, SystemMemory, PCH_PWRM_BASE_ADDRESS, PCH_PWRM_BASE_SIZE) Field(PWMR, DWordAcc, NoLock, Preserve) { @@ -73,6 +76,7 @@ Method (ULTR, 1, Serialized) { LTRU = Arg0 } +#endif
Method (_PS0, 0, Serialized) {