New patch to review for coreboot: 1bec24a drivers: Use DEVICE_NOOP macro over dummy symbol
Edward O'Callaghan (eocallaghan@alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7284 -gerrit commit 1bec24a30b366fce6f7d10d4fd71a26ec1e110c9 Author: Edward O'Callaghan <eocallaghan@alterapraxis.com> Date: Fri Oct 31 07:55:45 2014 +1100 drivers: Use DEVICE_NOOP macro over dummy symbol Change-Id: I931bd9c89bce6ac8f8e9e482a7876e2004abfb38 Signed-off-by: Edward O'Callaghan <eocallaghan@alterapraxis.com> --- src/drivers/i2c/adm1026/adm1026.c | 10 +++------- src/drivers/i2c/adm1027/adm1027.c | 10 +++------- src/drivers/i2c/adt7463/adt7463.c | 10 +++------- src/drivers/i2c/at24rf08c/at24rf08c.c | 10 +++------- src/drivers/i2c/i2cmux/i2cmux.c | 12 ++++-------- src/drivers/i2c/i2cmux2/i2cmux2.c | 12 ++++-------- src/drivers/i2c/lm63/lm63.c | 10 +++------- src/drivers/i2c/rtd2132/rtd2132.c | 10 +++------- src/drivers/i2c/w83793/w83793.c | 10 +++------- src/drivers/i2c/w83795/w83795.c | 10 +++------- src/drivers/ics/954309/ics954309.c | 10 +++------- 11 files changed, 35 insertions(+), 79 deletions(-) diff --git a/src/drivers/i2c/adm1026/adm1026.c b/src/drivers/i2c/adm1026/adm1026.c index e8baea1..592916a 100644 --- a/src/drivers/i2c/adm1026/adm1026.c +++ b/src/drivers/i2c/adm1026/adm1026.c @@ -44,14 +44,10 @@ static void adm1026_init(struct device *dev) } } -static void adm1026_noop(struct device *dummy) -{ -} - static struct device_operations adm1026_operations = { - .read_resources = adm1026_noop, - .set_resources = adm1026_noop, - .enable_resources = adm1026_noop, + .read_resources = DEVICE_NOOP, + .set_resources = DEVICE_NOOP, + .enable_resources = DEVICE_NOOP, .init = adm1026_init, }; diff --git a/src/drivers/i2c/adm1027/adm1027.c b/src/drivers/i2c/adm1027/adm1027.c index 9841c81..4e67e4d 100644 --- a/src/drivers/i2c/adm1027/adm1027.c +++ b/src/drivers/i2c/adm1027/adm1027.c @@ -50,14 +50,10 @@ static void adm1027_init(struct device *dev) } } -static void adm1027_noop(struct device *dummy) -{ -} - static struct device_operations adm1027_operations = { - .read_resources = adm1027_noop, - .set_resources = adm1027_noop, - .enable_resources = adm1027_noop, + .read_resources = DEVICE_NOOP, + .set_resources = DEVICE_NOOP, + .enable_resources = DEVICE_NOOP, .init = adm1027_init, }; diff --git a/src/drivers/i2c/adt7463/adt7463.c b/src/drivers/i2c/adt7463/adt7463.c index dd6d837..2fb42a9 100644 --- a/src/drivers/i2c/adt7463/adt7463.c +++ b/src/drivers/i2c/adt7463/adt7463.c @@ -85,14 +85,10 @@ static void adt7463_init(struct device *adt7463) printk(BIOS_DEBUG, "ADT7463 properly initialized\n"); } -static void adt7463_noop(struct device *dummy) -{ -} - static struct device_operations adt7463_operations = { - .read_resources = adt7463_noop, - .set_resources = adt7463_noop, - .enable_resources = adt7463_noop, + .read_resources = DEVICE_NOOP, + .set_resources = DEVICE_NOOP, + .enable_resources = DEVICE_NOOP, .init = adt7463_init, }; diff --git a/src/drivers/i2c/at24rf08c/at24rf08c.c b/src/drivers/i2c/at24rf08c/at24rf08c.c index a03564f..a9b821a 100644 --- a/src/drivers/i2c/at24rf08c/at24rf08c.c +++ b/src/drivers/i2c/at24rf08c/at24rf08c.c @@ -52,14 +52,10 @@ static void at24rf08c_init(struct device *dev) printk (BIOS_DEBUG, "init EEPROM done\n"); } -static void at24rf08c_noop(struct device *dummy) -{ -} - static struct device_operations at24rf08c_operations = { - .read_resources = at24rf08c_noop, - .set_resources = at24rf08c_noop, - .enable_resources = at24rf08c_noop, + .read_resources = DEVICE_NOOP, + .set_resources = DEVICE_NOOP, + .enable_resources = DEVICE_NOOP, .init = at24rf08c_init, }; diff --git a/src/drivers/i2c/i2cmux/i2cmux.c b/src/drivers/i2c/i2cmux/i2cmux.c index d8ad40b..1091653 100644 --- a/src/drivers/i2c/i2cmux/i2cmux.c +++ b/src/drivers/i2c/i2cmux/i2cmux.c @@ -16,15 +16,11 @@ static void i2cmux_set_link(struct device *dev, unsigned int link) } } -static void i2cmux_noop(struct device *dummy) -{ -} - static struct device_operations i2cmux_operations = { - .read_resources = i2cmux_noop, - .set_resources = i2cmux_noop, - .enable_resources = i2cmux_noop, - .init = i2cmux_noop, + .read_resources = DEVICE_NOOP, + .set_resources = DEVICE_NOOP, + .enable_resources = DEVICE_NOOP, + .init = DEVICE_NOOP, .scan_bus = scan_static_bus, .set_link = i2cmux_set_link, }; diff --git a/src/drivers/i2c/i2cmux2/i2cmux2.c b/src/drivers/i2c/i2cmux2/i2cmux2.c index 6b05508..fe48e76 100644 --- a/src/drivers/i2c/i2cmux2/i2cmux2.c +++ b/src/drivers/i2c/i2cmux2/i2cmux2.c @@ -15,15 +15,11 @@ static void i2cmux2_set_link(struct device *dev, unsigned int link) } } -static void i2cmux2_noop(struct device *dummy) -{ -} - static struct device_operations i2cmux2_operations = { - .read_resources = i2cmux2_noop, - .set_resources = i2cmux2_noop, - .enable_resources = i2cmux2_noop, - .init = i2cmux2_noop, + .read_resources = DEVICE_NOOP, + .set_resources = DEVICE_NOOP, + .enable_resources = DEVICE_NOOP, + .init = DEVICE_NOOP, .scan_bus = scan_static_bus, .set_link = i2cmux2_set_link, }; diff --git a/src/drivers/i2c/lm63/lm63.c b/src/drivers/i2c/lm63/lm63.c index b64751e..3ce5fd8 100644 --- a/src/drivers/i2c/lm63/lm63.c +++ b/src/drivers/i2c/lm63/lm63.c @@ -21,14 +21,10 @@ static void lm63_init(struct device *dev) } } -static void lm63_noop(struct device *dummy) -{ -} - static struct device_operations lm63_operations = { - .read_resources = lm63_noop, - .set_resources = lm63_noop, - .enable_resources = lm63_noop, + .read_resources = DEVICE_NOOP, + .set_resources = DEVICE_NOOP, + .enable_resources = DEVICE_NOOP, .init = lm63_init, }; diff --git a/src/drivers/i2c/rtd2132/rtd2132.c b/src/drivers/i2c/rtd2132/rtd2132.c index 4dbfb41..7bb2146 100644 --- a/src/drivers/i2c/rtd2132/rtd2132.c +++ b/src/drivers/i2c/rtd2132/rtd2132.c @@ -241,14 +241,10 @@ static void rtd2132_init(struct device *dev) } } -static void rtd2132_noop(struct device *dummy) -{ -} - static struct device_operations rtd2132_operations = { - .read_resources = rtd2132_noop, - .set_resources = rtd2132_noop, - .enable_resources = rtd2132_noop, + .read_resources = DEVICE_NOOP, + .set_resources = DEVICE_NOOP, + .enable_resources = DEVICE_NOOP, .init = rtd2132_init, }; diff --git a/src/drivers/i2c/w83793/w83793.c b/src/drivers/i2c/w83793/w83793.c index 732fdb4..4b947d7 100644 --- a/src/drivers/i2c/w83793/w83793.c +++ b/src/drivers/i2c/w83793/w83793.c @@ -220,14 +220,10 @@ static void w83793_init(struct device *dev) } -static void w83793_noop(struct device *dummy) -{ -} - static struct device_operations w83793_operations = { - .read_resources = w83793_noop, - .set_resources = w83793_noop, - .enable_resources = w83793_noop, + .read_resources = DEVICE_NOOP, + .set_resources = DEVICE_NOOP, + .enable_resources = DEVICE_NOOP, .init = w83793_init, }; diff --git a/src/drivers/i2c/w83795/w83795.c b/src/drivers/i2c/w83795/w83795.c index 5559666..569fe5a 100644 --- a/src/drivers/i2c/w83795/w83795.c +++ b/src/drivers/i2c/w83795/w83795.c @@ -239,14 +239,10 @@ static void w83795_hwm_init(struct device *dev) printk(BIOS_ERR, "Neither AMD nor INTEL CPU detected\n"); } -static void w83795_noop(struct device *dummy) -{ -} - static struct device_operations w83795_operations = { - .read_resources = w83795_noop, - .set_resources = w83795_noop, - .enable_resources = w83795_noop, + .read_resources = DEVICE_NOOP, + .set_resources = DEVICE_NOOP, + .enable_resources = DEVICE_NOOP, .init = w83795_hwm_init, }; diff --git a/src/drivers/ics/954309/ics954309.c b/src/drivers/ics/954309/ics954309.c index 0aa15c0..fda37af 100644 --- a/src/drivers/ics/954309/ics954309.c +++ b/src/drivers/ics/954309/ics954309.c @@ -55,14 +55,10 @@ static void ics954309_init(struct device *dev) smbus_block_write(dev, 0, 12, initdata); } -static void ics954309_noop(struct device *dummy) -{ -} - static struct device_operations ics954309_operations = { - .read_resources = ics954309_noop, - .set_resources = ics954309_noop, - .enable_resources = ics954309_noop, + .read_resources = DEVICE_NOOP, + .set_resources = DEVICE_NOOP, + .enable_resources = DEVICE_NOOP, .init = ics954309_init, };
participants (1)
-
Edward O'Callaghan