Hung-Te Lin has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32261
Change subject: google/kukui: Add variant 'Krane' ......................................................................
google/kukui: Add variant 'Krane'
Add the new configuration 'Krane' that will need at least its own EC. There's currently no difference in Coreboot side, simply a symlink.
BUG=b:130011505 TEST=make menuconfig; make -j # select board=Krane BRANCH=None
Change-Id: Ibb2ec42b08f9a51b22c22f3fe99b203f5eb31627 Signed-off-by: Hung-Te Lin hungte@chromium.org --- M src/mainboard/google/kukui/Kconfig M src/mainboard/google/kukui/Kconfig.name 2 files changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/32261/1
diff --git a/src/mainboard/google/kukui/Kconfig b/src/mainboard/google/kukui/Kconfig index 9f477e5..6831d1e 100644 --- a/src/mainboard/google/kukui/Kconfig +++ b/src/mainboard/google/kukui/Kconfig @@ -45,6 +45,7 @@ config MAINBOARD_PART_NUMBER string default "Kukui" if BOARD_GOOGLE_KUKUI + default "Krane" if BOARD_GOOGLE_KRANE default "Flapjack" if BOARD_GOOGLE_FLAPJACK
config DRIVER_TPM_SPI_BUS @@ -63,6 +64,7 @@ string depends on CHROMEOS default "KUKUI TEST 9847" if BOARD_GOOGLE_KUKUI + default "KRANE TEST 5417" if BOARD_GOOGLE_KRANE default "FLAPJACK TEST 4147" if BOARD_GOOGLE_FLAPJACK
endif diff --git a/src/mainboard/google/kukui/Kconfig.name b/src/mainboard/google/kukui/Kconfig.name index 6c84e26..348be66 100644 --- a/src/mainboard/google/kukui/Kconfig.name +++ b/src/mainboard/google/kukui/Kconfig.name @@ -4,6 +4,10 @@ bool "-> Kukui" select BOARD_GOOGLE_KUKUI_COMMON
+config BOARD_GOOGLE_KRANE + bool "-> Krane" + select BOARD_GOOGLE_KUKUI_COMMON + config BOARD_GOOGLE_FLAPJACK bool "-> Flapjack" select BOARD_GOOGLE_KUKUI_COMMON
Hello Julius Werner, You-Cheng Syu, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32261
to look at the new patch set (#2).
Change subject: google/kukui: Add variant 'Krane' ......................................................................
google/kukui: Add variant 'Krane'
Add the new configuration 'Krane' that will need at least its own EC. There's currently no difference in coreboot side, simply a symlink.
BUG=b:130011505 TEST=make menuconfig; make -j # select board=Krane BRANCH=None
Change-Id: Ibb2ec42b08f9a51b22c22f3fe99b203f5eb31627 Signed-off-by: Hung-Te Lin hungte@chromium.org --- M src/mainboard/google/kukui/Kconfig M src/mainboard/google/kukui/Kconfig.name 2 files changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/32261/2
Hello Julius Werner, You-Cheng Syu, build bot (Jenkins), Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32261
to look at the new patch set (#3).
Change subject: google/kukui: Add variant 'Krane' ......................................................................
google/kukui: Add variant 'Krane'
Add the new configuration 'Krane' that will need at least its own EC. There's currently no difference in coreboot side, simply a symlink.
BUG=b:130011505 TEST=make menuconfig; make -j # select board=Krane BRANCH=None
Change-Id: Ibb2ec42b08f9a51b22c22f3fe99b203f5eb31627 Signed-off-by: Hung-Te Lin hungte@chromium.org --- M src/mainboard/google/kukui/Kconfig M src/mainboard/google/kukui/Kconfig.name M src/mainboard/google/kukui/boardid.c 3 files changed, 10 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/32261/3
Hello Julius Werner, You-Cheng Syu, build bot (Jenkins), Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32261
to look at the new patch set (#4).
Change subject: google/kukui: Add variant 'Krane' ......................................................................
google/kukui: Add variant 'Krane'
Add the new configuration 'Krane' that will need at least its own EC. There's currently no difference in coreboot side, simply a symlink.
BUG=b:130011505 TEST=make menuconfig; make -j # select board=Krane BRANCH=None
Change-Id: Ibb2ec42b08f9a51b22c22f3fe99b203f5eb31627 Signed-off-by: Hung-Te Lin hungte@chromium.org --- M src/mainboard/google/kukui/Kconfig M src/mainboard/google/kukui/Kconfig.name 2 files changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/32261/4
You-Cheng Syu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32261 )
Change subject: google/kukui: Add variant 'Krane' ......................................................................
Patch Set 4: Code-Review+1
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32261 )
Change subject: google/kukui: Add variant 'Krane' ......................................................................
Patch Set 4: Code-Review+2
(1 comment)
https://review.coreboot.org/#/c/32261/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32261/4//COMMIT_MSG@10 PS4, Line 10: simply a symlink nit: symlink? I don't see any symlink? (FWIW please don't add any symlinks, this patch is fine as it is, just the message here seems wrong.)
Hello Julius Werner, You-Cheng Syu, build bot (Jenkins), Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32261
to look at the new patch set (#5).
Change subject: google/kukui: Add variant 'Krane' ......................................................................
google/kukui: Add variant 'Krane'
Add the new configuration 'Krane' that will need at least its own EC. There's currently no difference in coreboot side.
BUG=b:130011505 TEST=make menuconfig; make -j # select board=Krane BRANCH=None
Change-Id: Ibb2ec42b08f9a51b22c22f3fe99b203f5eb31627 Signed-off-by: Hung-Te Lin hungte@chromium.org --- M src/mainboard/google/kukui/Kconfig M src/mainboard/google/kukui/Kconfig.name 2 files changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/32261/5
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32261 )
Change subject: google/kukui: Add variant 'Krane' ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/#/c/32261/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32261/4//COMMIT_MSG@10 PS4, Line 10: simply a symlink
nit: symlink? I don't see any symlink? (FWIW please don't add any symlinks, this patch is fine as it […]
Done
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32261 )
Change subject: google/kukui: Add variant 'Krane' ......................................................................
Patch Set 5:
Can we merge this first? I need this so other pending changes in cros overlay can be merged, so we can have a krane specific build.
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32261 )
Change subject: google/kukui: Add variant 'Krane' ......................................................................
google/kukui: Add variant 'Krane'
Add the new configuration 'Krane' that will need at least its own EC. There's currently no difference in coreboot side.
BUG=b:130011505 TEST=make menuconfig; make -j # select board=Krane BRANCH=None
Change-Id: Ibb2ec42b08f9a51b22c22f3fe99b203f5eb31627 Signed-off-by: Hung-Te Lin hungte@chromium.org Reviewed-on: https://review.coreboot.org/c/coreboot/+/32261 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: You-Cheng Syu youcheng@google.com Reviewed-by: Julius Werner jwerner@chromium.org --- M src/mainboard/google/kukui/Kconfig M src/mainboard/google/kukui/Kconfig.name 2 files changed, 6 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Julius Werner: Looks good to me, approved You-Cheng Syu: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/kukui/Kconfig b/src/mainboard/google/kukui/Kconfig index 9f477e5..6831d1e 100644 --- a/src/mainboard/google/kukui/Kconfig +++ b/src/mainboard/google/kukui/Kconfig @@ -45,6 +45,7 @@ config MAINBOARD_PART_NUMBER string default "Kukui" if BOARD_GOOGLE_KUKUI + default "Krane" if BOARD_GOOGLE_KRANE default "Flapjack" if BOARD_GOOGLE_FLAPJACK
config DRIVER_TPM_SPI_BUS @@ -63,6 +64,7 @@ string depends on CHROMEOS default "KUKUI TEST 9847" if BOARD_GOOGLE_KUKUI + default "KRANE TEST 5417" if BOARD_GOOGLE_KRANE default "FLAPJACK TEST 4147" if BOARD_GOOGLE_FLAPJACK
endif diff --git a/src/mainboard/google/kukui/Kconfig.name b/src/mainboard/google/kukui/Kconfig.name index 6c84e26..348be66 100644 --- a/src/mainboard/google/kukui/Kconfig.name +++ b/src/mainboard/google/kukui/Kconfig.name @@ -4,6 +4,10 @@ bool "-> Kukui" select BOARD_GOOGLE_KUKUI_COMMON
+config BOARD_GOOGLE_KRANE + bool "-> Krane" + select BOARD_GOOGLE_KUKUI_COMMON + config BOARD_GOOGLE_FLAPJACK bool "-> Flapjack" select BOARD_GOOGLE_KUKUI_COMMON
-
Hung-Te Lin (Code Review) -
Julius Werner (Code Review)
-
Patrick Georgi (Code Review)
-
You-Cheng Syu (Code Review)