Attention is currently required from: Idwer Vollering, Paul Menzel. Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56677 )
Change subject: util/kconfig: detect ncurses on FreeBSD ......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
Does Linux’ Kconfig not work on FreeBSD? If it does work, the fix is something else, isn’t it?
This patch was part of coreboot's old patch set. I doubt the linux maintainers care whether you can build linux under FreeBSD.
I think that if 'make menuconfig' worked, Idwer probably wouldn't have bothered with the patch.
If anyone wants to track down a different fix and replace this with it, I'd have no problem with that This is a simple change and worked for FreeBSD before, so again, I see no problem with putting this change in. This is just looking in a different location for the ncurses library. Is there any issue with that?
-
Martin Roth (Code Review)