Attention is currently required from: Amanda Hwang, Dinesh Gehlot, Kapil Porwal, Nick Vaccaro, Paul Menzel, Subrata Banik.
Rishika Raj has posted comments on this change by Rishika Raj. ( https://review.coreboot.org/c/coreboot/+/83555?usp=email )
Change subject: mb/google/brya/variants/orisa: Remove dummy USB2 Port 10 entry
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83555/comment/929adc7c_ba604d1e?usp... :
PS2, Line 11:
Why was it added in the first place? […]
Initially, the entry was likely added by mistake.
File src/mainboard/google/brya/variants/orisa/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/83555/comment/0fc6cc61_c4cfdce2?usp... :
PS1, Line 453: chip drivers/usb/acpi
: register "desc" = ""USB2 Bluetooth""
: register "type" = "UPC_TYPE_INTERNAL"
: register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_A13)"
: device ref usb2_port10 on end
: end
need to delete this as well.
Acknowledged
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83555?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I355e4cdf70fbbc049d92265b0dee62e1d1545e36
Gerrit-Change-Number: 83555
Gerrit-PatchSet: 2
Gerrit-Owner: Rishika Raj
rishikaraj@google.com
Gerrit-Reviewer: Amanda Hwang
amanda_hwang@compal.corp-partner.google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Amanda Hwang
amanda_hwang@compal.corp-partner.google.com
Gerrit-Comment-Date: Mon, 22 Jul 2024 10:03:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org