Attention is currently required from: Paul Menzel.
Stanley Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76876?usp=email )
Change subject: mb/google/dedede/var/boxy: Add power limits for N4500/N5100 ......................................................................
Patch Set 2:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/76876/comment/e9dd8fdf_e46d94d4 : PS1, Line 7: Add power limits
Maybe more specific: Add power limits for N4500/N5100
Done
https://review.coreboot.org/c/coreboot/+/76876/comment/f1bacaa5_4602a1b6 : PS1, Line 7: for Boxy
Redundant, as already in prefix.
Done
https://review.coreboot.org/c/coreboot/+/76876/comment/69cf26e5_44b17af1 : PS1, Line 5: ommitDate: 2023-08-01 11:43:35 +0800 : : mb/google/dedede/var/boxy:Add
Please add a space after the colon.
Done
https://review.coreboot.org/c/coreboot/+/76876/comment/62b369ba_6aff0119 : PS1, Line 9: JSL PDG
Please also add the document id.
Done
https://review.coreboot.org/c/coreboot/+/76876/comment/01641a79_ba12fdbb : PS1, Line 12: TEST=emerge-dedede coreboot and read correct value on boxy
How can this be read?
BIOS log will show the values during post.