Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Felix Held.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55571 )
Change subject: [WIP] soc/amd: Use madt_ioapic_from_hw()
......................................................................
Patch Set 1:
(2 comments)
Patchset:
PS1:
gave this one a try and linux kernel panicked during boot and complained that the "timer doesn't wor […]
Thanks for testing.
Seems like static FCH_IOAPIC_ID and GNB_IOAPIC_ID are passed to FSP-S or FSP-M. So it's better not to use the auto-incrementing scheme for I/O APIC IDs here.
I think it depends of PCI BDF order, not linking order.
File src/soc/amd/picasso/acpi.c:
https://review.coreboot.org/c/coreboot/+/55571/comment/b9ae8687_29d61518
PS1, Line 40: GNB_IO_APIC_ADDR);
Reviewed elsewhere; it should be allowed to swap the order of the two calls above, but currently that changes GSI assignments too.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55571
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifdacc61b72f461ec6bea334fa06651c09a9695d6
Gerrit-Change-Number: 55571
Gerrit-PatchSet: 1
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 17 Jun 2021 03:34:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment