Attention is currently required from: Dinesh Gehlot, Edward Doan, Eric Lai, Jamie Chen, Kapil Porwal, Nick Vaccaro, Subrata Banik, YH Lin.
SH Kim has posted comments on this change by SH Kim. ( https://review.coreboot.org/c/coreboot/+/83346?usp=email )
Change subject: mb/google/brya/var/xol: Change touchpad I2C interrupt type to GPIO_INT
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
we might need to dig deep to find out why the behavior is not identical with other Brya platform tha […]
Please refer to the bug for the detail. Add Jamie@intel for any further question.
- We can refer to this comment for why we have IOAPIC configuration has this problem.: https://partnerissuetracker.corp.google.com/issues/350609957#comment22. I just assume GPI_INT has differt mechanism to handle its interrupt status in SoC or GPIO driver, Intel can help for any comment about it.
- We had discussion with device vendor in the bug, they said cannot change interrupt signal timing in device firmware.: https://partnerissuetracker.corp.google.com/issues/350609957#comment27
- We had 2 options for this problem, one was a patch in kernel side and another one was this patch. And we choose this change for Xol.
- Actually we didn't try Edge Single interrupt configuration but I think it may cause DUT to miss interrupts from device on continuous user input on touchpad.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83346?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie1b59355a694e5a42367a20e03f6c5f93225e79c
Gerrit-Change-Number: 83346
Gerrit-PatchSet: 3
Gerrit-Owner: SH Kim
sh_.kim@samsung.corp-partner.google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Edward Doan
edoan@chromium.org
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Jamie Chen
jamie.chen@intel.corp-partner.google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: SH Kim
sh_.kim@samsung.corp-partner.google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: YH Lin
yueherngl@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Edward Doan
edoan@chromium.org
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Jamie Chen
jamie.chen@intel.corp-partner.google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: YH Lin
yueherngl@chromium.org
Gerrit-Comment-Date: Thu, 18 Jul 2024 05:28:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com