Attention is currently required from: Arthur Heymans. Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55070 )
Change subject: link Agesa into bootblock ......................................................................
Patch Set 15:
(5 comments)
File src/arch/x86/Kconfig:
https://review.coreboot.org/c/coreboot/+/55070/comment/aa64dc4e_4d4bc302 PS15, Line 183: default 0x100000 if !FIXED_BOOTBLOCK_SIZE I agree you need it, but maybe not in an AGESA-specific commit if you change it for everyone. And maybe the increase should be conditional on !SEPARATE_ROMSTAGE.
File src/arch/x86/bootblock.ld:
https://review.coreboot.org/c/coreboot/+/55070/comment/9bea5ec7_ab9c28dc PS15, Line 29: It's still XIP without .data ?
File src/cpu/amd/agesa/Kconfig:
https://review.coreboot.org/c/coreboot/+/55070/comment/9547fee3_2b395348 PS15, Line 49: default 0xFFF00000 We should just get of this. Make the move conditional for now.
File src/drivers/amd/agesa/romstage.c:
https://review.coreboot.org/c/coreboot/+/55070/comment/03f153d3_c78f3cc8 PS15, Line 32: */ Left-over comment
https://review.coreboot.org/c/coreboot/+/55070/comment/556ded1f_231b3760 PS15, Line 47: set_ap_entry_ptr(ap_romstage_main); You might as well add
if (CONFIG(SEPARATE_ROMSTAGE))
-
Kyösti Mälkki (Code Review)