Attention is currently required from: Furquan Shaikh, Nick Vaccaro, EricR Lai. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58180 )
Change subject: mb/google/brya: Clear SLP_S0_GATE_L on ACPI sleep entry ......................................................................
Patch Set 1:
(2 comments)
File src/mainboard/google/brya/mainboard.asl:
https://review.coreboot.org/c/coreboot/+/58180/comment/3c85115e_45c0d046 PS1, Line 30: S5 shutdown
This is not just S5 shutdown but any sleep entry, right? […]
On entry of S1-S5 yes. _PTS is not called for s2idle cases (ACPI has different s2idle vs. suspend PM ops, and the s2idle prepare callback does not end up calling _PTS. Otherwise I think there would be no need for the LPIT S0ix hooks?
Updated comment 😊
https://review.coreboot.org/c/coreboot/+/58180/comment/4568d8e2_7657a2cb PS1, Line 33: */
Add comment that this gets reconfigured correctly on wake from sleep path i.e. in ramstage.
Done