Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43850 )
Change subject: soc/intel/tigerlake: Invoke PCIe root port swapping
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43850/1/src/soc/intel/tigerlake/chi...
File src/soc/intel/tigerlake/chip.c:
https://review.coreboot.org/c/coreboot/+/43850/1/src/soc/intel/tigerlake/chi...
PS1, Line 21: PCH_DEV_SLOT_PCIE
There also seems to be PCH_DEV_SLOT_PCIE_1 with 4 functions. […]
In JSL, we only have 8 PCIe root ports and hence added only those ports. TGL seems to have more - 12 root ports. So as Duncan mentioned, PCH_DEV_SLOT_PCIE_1 needs to be included. I can see them listed in the devicetree and also some of them enabled in the devicetree.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43850
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9230de8b1818f3f2115dab923841fd0e7778be62
Gerrit-Change-Number: 43850
Gerrit-PatchSet: 1
Gerrit-Owner: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 27 Jul 2020 15:56:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Duncan Laurie
dlaurie@chromium.org
Gerrit-MessageType: comment