[M] Change in coreboot[master]: drivers/ocp: add VPD processing framework - coreboot-gerrit

12 Nov 2022


      Attention is currently required from: Marc Jones, Jonathan Zhang, Johnny Lin, Paul Menzel, Johnny Li, Shuming Chu (Shuming), Angel Pons, Tim Chu.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68784 )
Change subject: drivers/ocp: add VPD processing framework
......................................................................
Patch Set 2:
(1 comment)
File src/drivers/ocp/vpd/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/68784/comment/e43993e2_e8746d1e 
PS2, Line 3: smm-$(C
It's not a good idea to fetch VPD in the smihandler. Do you really need this?
Also where is this Kconfig option defined? I don't see it in this patch.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/68784
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I705bea348b1611f25ccbd798b77cfee22ec30f0f
Gerrit-Change-Number: 68784
Gerrit-PatchSet: 2
Gerrit-Owner: Jonathan Zhang jonzhang@fb.com
Gerrit-Reviewer: Angel Pons angel.pons@9elements.com
Gerrit-Reviewer: Johnny Li johnny_li@wistron.corp-partner.google.com
Gerrit-Reviewer: Johnny Lin Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Marc Jones marc@marcjonesconsulting.com
Gerrit-Reviewer: Paul Menzel paulepanter@mailbox.org
Gerrit-Reviewer: Tim Chu Tim.Chu@quantatw.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Arthur Heymans arthur@aheymans.xyz
Gerrit-CC: Shuming Chu (Shuming) s1218944@gmail.com
Gerrit-Attention: Marc Jones marc@marcjonesconsulting.com
Gerrit-Attention: Jonathan Zhang jonzhang@fb.com
Gerrit-Attention: Johnny Lin Johnny_Lin@wiwynn.com
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Johnny Li johnny_li@wistron.corp-partner.google.com
Gerrit-Attention: Shuming Chu (Shuming) s1218944@gmail.com
Gerrit-Attention: Angel Pons angel.pons@9elements.com
Gerrit-Attention: Tim Chu Tim.Chu@quantatw.com
Gerrit-Comment-Date: Sat, 12 Nov 2022 08:00:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment