[M] Change in coreboot[master]: mb/google/corsola: Report SKU and panel ID for unprovisioned devices
Attention is currently required from: Hung-Te Lin, Yu-Ping Wu, Yidi Lin, cong yang.
Ruihai Zhou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74135 )
Change subject: mb/google/corsola: Report SKU and panel ID for unprovisioned devices ......................................................................
Patch Set 8:
(6 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74135/comment/f58d9bde_ea37af87 PS6, Line 9: mipi
MIPI
Done
https://review.coreboot.org/c/coreboot/+/74135/comment/c140e9c6_959f16be PS6, Line 10: mipi panel
MIPI panels
Done
File src/mainboard/google/corsola/boardid.c:
https://review.coreboot.org/c/coreboot/+/74135/comment/63042264_e0d0b43a PS6, Line 79: adc_voltages_table = adc_voltages_detachable;
Just `voltages = adc_voltages_detachable[channel]` here and no need for `adc_voltages_table`.
Done, thank you.
https://review.coreboot.org/c/coreboot/+/74135/comment/e107f441_54608c71 PS6, Line 113: if (cached_sku_code == BOARD_ID_INIT) {
Since the logic becomes complicated, let's return here if `cached_sku_code != BOARD_ID_INIT`. […]
Done
https://review.coreboot.org/c/coreboot/+/74135/comment/27b0dded_ddba7cdd PS6, Line 116: #if (CONFIG(BOARD_GOOGLE_STARMIE_COMMON))
Use `if (CONFIG(BOARD_GOOGLE_STARMIE_COMMON))
Done
https://review.coreboot.org/c/coreboot/+/74135/comment/4b9e71d4_426ff961 PS6, Line 126: if (cached_sku_code == CROS_SKU_UNKNOWN) {
I think we can also add `cached_sku_code == CROS_SKU_UNPROVISIONED` here, so that the "if" statement […]
I think the CROS_SKU_UNPROVISIONED sku id is expected for kingler/krabby board, we don't want to change it to adc mapping value
-
Ruihai Zhou (Code Review)