Attention is currently required from: Tarun Tuli, Kapil Porwal, Paul Menzel, Eric Lai.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74306 )
Change subject: soc/intel/meteorlake: Hook up UPD CnviWifiCore
......................................................................
Patch Set 3:
(1 comment)
File src/soc/intel/meteorlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/74306/comment/a8017226_230f763a
PS3, Line 565: s_cfg->CnviWifiCore = config->cnvi_wifi_core;
not sure about this, assert is prevent the setting wrong. kind of different idea to force it disable like the CnviBT?
as we would like to create a dependency between CnviMode and CnviWifiCore UPDs, it's better to club both under the same umbrella rather. This would help to ensure that WiFi core can't be enabled without enabling the CNVi itself. `assert` is meaningful for debug only features and when the outcome is not known. In this case, we for sure knw the dependency between those two UPDs.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74306
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5b4662c2a064f7c9074797c8a2541dcf1dd686fe
Gerrit-Change-Number: 74306
Gerrit-PatchSet: 3
Gerrit-Owner: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Comment-Date: Wed, 12 Apr 2023 08:33:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-MessageType: comment