Attention is currently required from: Paul Menzel, Kenneth Chan. Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59839 )
Change subject: mb/google/guybrush/var/dewatt: Add dewatt device config ......................................................................
Patch Set 3:
(4 comments)
Patchset:
PS3: Please split this CL into separate CLs for each functional change
0.Override SPKR_EN GPIO 1.Add Synaptics S9831 touch pad for dewatt. 2.Add Elan 6918 touch screen for dewatt. 3.Add Realtek 5682 and ALC1019 for dewatt.
File src/mainboard/google/guybrush/variants/dewatt/gpio.c:
https://review.coreboot.org/c/coreboot/+/59839/comment/0d0229cb_96b76bcc PS3, Line 11: static const struct soc_amd_gpio bid1_override_gpio_table[] = { bid1_override_gpio_table and bid2_override_gpio_table are the same, only one is needed.
https://review.coreboot.org/c/coreboot/+/59839/comment/f0d03a75_e794e62b PS3, Line 43: return bid2_override_gpio_table; Just return NULL if the table is emtpy.
https://review.coreboot.org/c/coreboot/+/59839/comment/6b1dd571_158c3b3e PS3, Line 49: return override_early_gpio_table; If the table is empty, just return NULL and delete the table.
-
Rob Barnes (Code Review)