[L] Change in coreboot[master]: mb/google/nissa/var/gothrax: Initialise overridetree

[Yunlong Jia (Code Review)]

Attention is currently required from: Derek Huang, Felix Singer, Henry Sun, Tarun Tuli.

Yunlong Jia has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76013?usp=email )

Change subject: mb/google/nissa/var/gothrax: Initialise overridetree
......................................................................

Patch Set 6:

(6 comments)

File src/mainboard/google/brya/variants/gothrax/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/76013/comment/7acc3cf9_01fbfac8 :
PS1, Line 34: 	register "usb2_ports[4]" = "USB2_PORT_MID(OC_SKIP)"	# USB2_A1
            : 	register "usb2_ports[6]" = "USB2_PORT_MID(OC_SKIP)"	# WFC
            : 	register "usb2_ports[7]" = "USB2_PORT_MID(OC_SKIP)"	# Bluetooth port for PCIe WLAN
            : 	register "usb2_ports[9]" = "USB2_PORT_MID(OC_SKIP)"	# Bluetooth port for CNVi WLAN
            : 
            : 	register "usb3_ports[2]" = "USB3_PORT_DEFAULT(OC_SKIP)"	# USB3/3 Type A port A1
> I just don't know where is the best place to put it. […]

Done

https://review.coreboot.org/c/coreboot/+/76013/comment/ba8e149d_af0c9c2d :
PS1, Line 34: register "usb2_ports[4]" = "USB2_PORT_MID(OC_SKIP)"	# USB2_A1
            : 	register "usb2_ports[6]" = "USB2_PORT_MID(OC_SKIP)"	# WFC
            : 	register "usb2_ports[7]" = "USB2_PORT_MID(OC_SKIP)"	# Bluetooth port for PCIe WLAN
            : 	register "usb2_ports[9]" = "USB2_PORT_MID(OC_SKIP)"	# Bluetooth port for CNVi WLAN
            : 
            : 	register "usb3_ports[2]" = "USB3_PORT_DEFAULT(OC_SKIP)"	# USB3/3 Type A port A1
            :
> I'm Sorry for commenting late. […]

Done

File src/mainboard/google/brya/variants/gothrax/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/76013/comment/d6ba56db_ca6f8314 :
PS3, Line 168: probed
> We see that some places use "detect" and "probed", so what is the difference between the two?

We don't have this `detect`.

https://review.coreboot.org/c/coreboot/+/76013/comment/67593f13_80f6d755 :
PS3, Line 176: 				device i2c 0x10 on end
> Do you mean that we need to "stop_gpio" on the Touchscreen at a certain time?

we don't think we need it．

File src/mainboard/google/brya/variants/gothrax/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/76013/comment/2e6d6f03_d9977cff :
PS4, Line 332: 			register "usb2_ports[6]" = "USB2_PORT_MID(OC_SKIP)"     # WFC
> > trailing whitespace […]

Done

https://review.coreboot.org/c/coreboot/+/76013/comment/d3db295f_398f97f3 :
PS4, Line 335: 			register "usb3_ports[2]" = "USB3_PORT_DEFAULT(OC_SKIP)" # USB3/3 Type A port A1
> add an empty line here

Done