Attention is currently required from: Benjamin Doron, Krystian Hebel, Lean Sheng Tan, Matt DeVillier, Sergii Dmytruk.
Sean Rhodes has posted comments on this change by Sergii Dmytruk. ( https://review.coreboot.org/c/coreboot/+/83682?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: payloads/edk2: configure capsule updates
......................................................................
Patch Set 6: Code-Review-1
(1 comment)
Patchset:
PS6:
I don't think we should have build options that aren't upstreamed in coreboot, especially as we have EDK2_CUSTOM_BUILD_PARAMSd.
Matt's branch is the exception as it's has been the default in coreboot for ages.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83682?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I1c684cb8929842a5d3c4b06e8a9c0a748470ea41
Gerrit-Change-Number: 83682
Gerrit-PatchSet: 6
Gerrit-Owner: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Reviewer: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Attention: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Comment-Date: Wed, 02 Oct 2024 18:59:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes