Attention is currently required from: Benjamin Doron, David Milosevic, Julius Werner.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78284?usp=email )
Change subject: arch/arm64: Support calling a trusted monitor
......................................................................
Patch Set 15:
(2 comments)
File src/arch/arm64/smc.c:
https://review.coreboot.org/c/coreboot/+/78284/comment/9d83e760_651a11c4 :
PS15, Line 6: extern
The extern keyword is meaningless for functions.
https://review.coreboot.org/c/coreboot/+/78284/comment/57112df0_7ea8cda9 :
PS15, Line 9: inline
I don't think inline works without static: You want it to be exported at the compilation module level which makes inlining impossible (LTO might inline it after all).
Do you see a difference at binary level?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78284?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I158db0b971aba722b3995d52162146aa406d1644
Gerrit-Change-Number: 78284
Gerrit-PatchSet: 15
Gerrit-Owner: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: David Milosevic
David.Milosevic@9elements.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: David Milosevic
David.Milosevic@9elements.com
Gerrit-Comment-Date: Mon, 22 Apr 2024 08:04:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment