Attention is currently required from: Tim Wawrzynczak.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63555 )
Change subject: cpu/x86/mtrr.c: Allow for multiple TEMP MTRR ranges
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
Practically speaking though, for almost all of these CPUs, the OS will use PATs anyway, and likely disregard the MTRRs.
MTRR setup is already wrong/inefficient on soc/intel (sets up UC for ranges between cbmem_top and TSEG)... On some setups it might make the MTRR caching setup worse such that it slows down the payload a lot if it runs out MTRRs... I'd prefer to avoid possible regressions there.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63555
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I23442bd2ab7602e4c5cbd37d187a31413cf27ecc
Gerrit-Change-Number: 63555
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Mon, 11 Apr 2022 20:41:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment