Attention is currently required from: Raul Rangel, Jon Murphy, Karthik Ramasubramanian. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62903 )
Change subject: mb/google/skyrim: Add DXIO descriptors ......................................................................
Patch Set 5:
(1 comment)
File src/mainboard/google/skyrim/variants/baseboard/include/baseboard/variants.h:
https://review.coreboot.org/c/coreboot/+/62903/comment/d148c451_0b5a3a3f PS3, Line 10: #define WLAN_DEVFN PCIE_GPP_2_0_DEVFN : #define SD_DEVFN PCIE_GPP_2_1_DEVFN
i'm not certain if those device functions need to be swapped. […]
looking at the schematics i wonder if the mapping between logical and physical lanes is a 1:1 mapping or if it's jut the same numbers, but counted backwards. if it's counted backwards, this mapping would be correct, but i'm not sure if it's 1:1 or counted backwards
-
Felix Held (Code Review)