Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Matt DeVillier, Kyösti Mälkki, Fred Reitberger.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55571 )
Change subject: soc/amd: Use ioapic helper functions
......................................................................
Patch Set 11: Code-Review+1
(3 comments)
Patchset:
PS1:
Thanks, I removed [WIP]. […]
i'll try to run a test today
Patchset:
PS11:
as a follow-up to this patch i can look into using get_ioapic_id in soc/amd/common/block/acpi/ivrs.c:acpi_fill_ivrs_ioapic. apart from the ioapic ids passed to the fsp that should be the remaining part with hard-coded ioapic ids
File src/soc/amd/cezanne/root_complex.c:
https://review.coreboot.org/c/coreboot/+/55571/comment/c1e6fad1_116ad6b1
PS1, Line 179: setup_ioapic((u8 *)GNB_IO_APIC_ADDR, GNB_IOAPIC_ID);
Mentioned in the commit message, do you want more about this?
looks good to me
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55571
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifdacc61b72f461ec6bea334fa06651c09a9695d6
Gerrit-Change-Number: 55571
Gerrit-PatchSet: 11
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Comment-Date: Tue, 15 Nov 2022 10:41:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment