Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46994 )
Change subject: nb/intel/haswell: Drop invalid MMIO_PAVP_MSG write ......................................................................
nb/intel/haswell: Drop invalid MMIO_PAVP_MSG write
This write was copied from Sandy Bridge. Neither Haswell reference code nor Broadwell perform this write. Therefore, it is safe to remove it.
Change-Id: I8869ff3e66362d9910235c554c3a07e91f479a82 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/northbridge/intel/haswell/northbridge.c 1 file changed, 0 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/46994/1
diff --git a/src/northbridge/intel/haswell/northbridge.c b/src/northbridge/intel/haswell/northbridge.c index e31337b..bbc6bf6 100644 --- a/src/northbridge/intel/haswell/northbridge.c +++ b/src/northbridge/intel/haswell/northbridge.c @@ -585,9 +585,6 @@ /* Configure turbo power limits 1ms after reset complete bit */ mdelay(1); set_power_limits(28); - - /* Set here before graphics PM init. */ - MCHBAR32(MMIO_PAVP_MSG) = 0x00100001; }
static struct device_operations mc_ops = {
Attention is currently required from: Nico Huber. Hello build bot (Jenkins), Nico Huber, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46994
to look at the new patch set (#13).
Change subject: nb/intel/haswell: Drop incorrect MMIO_PAVP_MSG write ......................................................................
nb/intel/haswell: Drop incorrect MMIO_PAVP_MSG write
This write was copied from Sandy Bridge. Neither Haswell reference code nor Broadwell perform this write. Therefore, it is safe to remove it.
Change-Id: I8869ff3e66362d9910235c554c3a07e91f479a82 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/northbridge/intel/haswell/northbridge.c 1 file changed, 0 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/46994/13
Attention is currently required from: Angel Pons. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46994 )
Change subject: nb/intel/haswell: Drop incorrect MMIO_PAVP_MSG write ......................................................................
Patch Set 13: Code-Review+2
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/46994/comment/25f150ae_eda651f1 PS13, Line 10: is seems?
Attention is currently required from: Angel Pons. Hello build bot (Jenkins), Nico Huber, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46994
to look at the new patch set (#14).
Change subject: nb/intel/haswell: Drop incorrect MMIO_PAVP_MSG write ......................................................................
nb/intel/haswell: Drop incorrect MMIO_PAVP_MSG write
This write was copied from Sandy Bridge. Neither Haswell reference code nor Broadwell perform this write. Therefore, it seems safe to remove it.
Change-Id: I8869ff3e66362d9910235c554c3a07e91f479a82 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/northbridge/intel/haswell/northbridge.c 1 file changed, 0 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/46994/14
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46994 )
Change subject: nb/intel/haswell: Drop incorrect MMIO_PAVP_MSG write ......................................................................
nb/intel/haswell: Drop incorrect MMIO_PAVP_MSG write
This write was copied from Sandy Bridge. Neither Haswell reference code nor Broadwell perform this write. Therefore, it seems safe to remove it.
Change-Id: I8869ff3e66362d9910235c554c3a07e91f479a82 Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/46994 Reviewed-by: Nico Huber nico.h@gmx.de Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/northbridge/intel/haswell/northbridge.c 1 file changed, 0 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved
diff --git a/src/northbridge/intel/haswell/northbridge.c b/src/northbridge/intel/haswell/northbridge.c index c59dce7..130c0ff 100644 --- a/src/northbridge/intel/haswell/northbridge.c +++ b/src/northbridge/intel/haswell/northbridge.c @@ -547,9 +547,6 @@ /* Configure turbo power limits 1ms after reset complete bit. */ mdelay(1); set_power_limits(28); - - /* Set here before graphics PM init. */ - MCHBAR32(MMIO_PAVP_MSG) = 0x00100001; }
static struct device_operations mc_ops = {
-
Angel Pons (Code Review) -
Nico Huber (Code Review)
-
Patrick Georgi (Code Review)