Attention is currently required from: Angel Pons, Martin L Roth, Nico Huber.
Nicholas Chin has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/83185?usp=email )
Change subject: util/autoport: Add CC-PDDC SPDX header to empty files
......................................................................
Patch Set 5:
(2 comments)
File util/autoport/main.go:
https://review.coreboot.org/c/coreboot/+/83185/comment/fe0d6c3b_e417506c?usp... :
PS4, Line 244: fmt.Fprintln(f)
This adds an extra newline
Fixed
https://review.coreboot.org/c/coreboot/+/83185/comment/d5eda26d_e46ee9c3?usp... :
PS4, Line 245: }
Suggestion: You could turn it around and have a new function that […]
Created an alternative to this patch implementing that idea here: https://review.coreboot.org/c/coreboot/+/84329
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83185?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5fdf0c80443a79c082b3d0418d16cd858782b2c9
Gerrit-Change-Number: 83185
Gerrit-PatchSet: 5
Gerrit-Owner: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Thu, 12 Sep 2024 02:53:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Nicholas Chin
nic.c3.14@gmail.com