Attention is currently required from: Arthur Heymans, Patrick Rudolph, Christian Walter.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62649 )
Change subject: [WIP]mb/prodrive/hermes: Change gfx init depending on eeprom config
......................................................................
Patch Set 1:
(3 comments)
File src/mainboard/prodrive/hermes/mainboard.c:
https://review.coreboot.org/c/coreboot/+/62649/comment/cb6f4781_0932fd0b
PS1, Line 262: internale_gfx
There's a typo, and enum type is unused anyway. I'd also move it closer to `mainboard_configure_internal_gfx()`
https://review.coreboot.org/c/coreboot/+/62649/comment/da1727e3_ad4ca10e
PS1, Line 280: mainboard_configure_internal_gfx
Why not call this from `mainboard_early()`?
https://review.coreboot.org/c/coreboot/+/62649/comment/e1a6f1fe_cb2abd57
PS1, Line 283: board_cfg
This can be NULL.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62649
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I24d9ebc2055dc246e7f257aa2f3853b22c8af370
Gerrit-Change-Number: 62649
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Mon, 07 Mar 2022 17:35:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment