Attention is currently required from: Martin Roth.
Lance Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49317 )
Change subject: drivers/uart: Add ACPI SPCR table generation.
......................................................................
Patch Set 1:
(1 comment)
File src/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/49317/comment/01ace85b_d3265217
PS1, Line 1669: 1
Though it may not matter that much, but from https://docs.microsoft.com/en-us/windows-hardware/drivers/serports/serial-po...
Revision 1 8 2
that shall be 2?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49317
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib1e7c17adcf5b2a8206a8308e057855819ec413a
Gerrit-Change-Number: 49317
Gerrit-PatchSet: 1
Gerrit-Owner: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Comment-Date: Tue, 12 Jan 2021 02:30:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment