[XS] Change in coreboot[main]: mb/google/brox/variants/brox: remove PL4 value modification

[Sowmya Aralguppe (Code Review)]

Attention is currently required from: Balaji Manigandan, Eric Lai, Karthik Ramasubramanian, Paul Menzel, Shelley Chen, Subrata Banik, Sumeet R.P..

Sowmya Aralguppe has posted comments on this change by Sumeet R.P.. ( https://review.coreboot.org/c/coreboot/+/83662?usp=email )

Change subject: mb/google/brox/variants/brox: remove PL4 value modification
......................................................................

Patch Set 4: Code-Review+1

(3 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/83662/comment/4ce093c5_2a1f5364?usp... :
PS3, Line 7: mb/google/brox/variants/brox:remove PL4 value modification
> Please add a space after the colon (:).

Done

https://review.coreboot.org/c/coreboot/+/83662/comment/8894cc7f_17498e8a?usp... :
PS3, Line 9: Remove PL4 value modification based on PsysPL3 value.
> Why?

For Brox -pl4 value is fixed as 114 watts. It was wrongly getting modified to 113watts based on psyspl3.This impacted power and performance measurements for Brox. This patch is addressing that issue by removing pl4 modification.

https://review.coreboot.org/c/coreboot/+/83662/comment/e091fda0_b5b79546?usp... :
PS3, Line 13: TEST=Built and boot on brox system
> What difference can be seen?

we can check pl4 value to be initialized at 114 watts