Change in coreboot[master]: cbfstool: Do host space address conversion earlier when adding files - coreboot-gerrit

10 Dec 2021


      Attention is currently required from: Patrick Georgi, Paul Menzel, Julius Werner.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60018 )
Change subject: cbfstool: Do host space address conversion earlier when adding files
......................................................................
Patch Set 4: Code-Review+2
(1 comment)
File util/cbfstool/cbfstool.c:
https://review.coreboot.org/c/coreboot/+/60018/comment/af217561_f96f7637 
PS3, Line 1052: offset
...
I agree with Julius, it's probably something that needs fixing wholesale or not, otherwise it may ju […]
Yeah, I was more talking as a followup/cleanup.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/60018
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idf4721c5b0700789ddb81c1618d740b3e7f486cb
Gerrit-Change-Number: 60018
Gerrit-PatchSet: 4
Gerrit-Owner: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Patrick Georgi patrick@coreboot.org
Gerrit-Reviewer: Paul Menzel paulepanter@mailbox.org
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Patrick Georgi patrick@coreboot.org
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Julius Werner jwerner@chromium.org
Gerrit-Comment-Date: Fri, 10 Dec 2021 19:11:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Raul Rangel rrangel@chromium.org
Comment-In-Reply-To: Tim Wawrzynczak twawrzynczak@chromium.org
Comment-In-Reply-To: Julius Werner jwerner@chromium.org
Gerrit-MessageType: comment