Attention is currently required from: Dinesh Gehlot, Dtrain Hsu, Eric Lai, Jayvik Desai, John Su, Nick Vaccaro, Subrata Banik.
Kapil Porwal has posted comments on this change by John Su. ( https://review.coreboot.org/c/coreboot/+/85581?usp=email )
Change subject: mb/trulo/var/uldrenite: Configuration serial_io and I2C ......................................................................
Patch Set 2:
(7 comments)
File src/mainboard/google/brya/Kconfig:
https://review.coreboot.org/c/coreboot/+/85581/comment/ae4359e7_7f1c4846?usp... : PS2, Line 615: select SOC_INTEL_TWINLAKE Move it to another CL. May be a new CL.
File src/mainboard/google/brya/variants/uldrenite/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/85581/comment/5d86aabf_603b8b4f?usp... : PS2, Line 96: # FIXME: To be enabled in future based on PNP impact data. : # Disable Package C-state demotion for nissa baseboard. : register "disable_package_c_state_demotion" = "true" Move to PnP CL
https://review.coreboot.org/c/coreboot/+/85581/comment/2b7ccaad_314be38e?usp... : PS2, Line 221: probed Change it to `detect`
https://review.coreboot.org/c/coreboot/+/85581/comment/0a446ae7_76992e83?usp... : PS2, Line 237: 280 Same as below
https://review.coreboot.org/c/coreboot/+/85581/comment/e04c85ff_989eea71?usp... : PS2, Line 255: 300 This is very high. This will impact s0ix suspend/resume time.
https://review.coreboot.org/c/coreboot/+/85581/comment/b6aa4708_39bf0eec?usp... : PS2, Line 306: device ref heci1 on end Move to PnP CL
https://review.coreboot.org/c/coreboot/+/85581/comment/938f68f4_e0a79fc6?usp... : PS2, Line 314: device ref pmc hidden end Move to PnP CL